Skip to contentSkip to conversation

pixman: check neon support via TUNE_FEATURES, not the _armv7a over-ride

PATCH New Andre McCurdy 1 participant 1 message Dec 17, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pixman: check neon support via TUNE_FEATURES, not the _armv7a over-ride

Neon support is optional in armv7a so the _armv7a over-ride is not the best way to determine whether or not the target supports neon.

Since pixman will always use neon in preference to 'simd' (ie VFPv2) if it can, it's safe to disable the simd routines if the target is known to support neon.

---
 meta/recipes-graphics/xorg-lib/pixman_0.32.8.bb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
meta/recipes-graphics/xorg-lib/pixman_0.32.8.bb +3 -4
index e13b9ad..16e68fc 100644
@@ -19,13 +19,12 @@ PE = "1"
 
 IWMMXT = "--disable-arm-iwmmxt"
 LOONGSON_MMI = "--disable-loongson-mmi"
-NEON = " --disable-arm-neon "
-NEON_class-nativesdk = " --disable-arm-neon "
-NEON_armv7a = " "
-NEON_armv7a-vfp-neon = " "
+# If target supports neon then disable the 'simd' (ie VFPv2) fallback, otherwise disable neon.
+NEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--disable-arm-simd", "--disable-arm-neon" ,d)}"
 
 EXTRA_OECONF = "--disable-gtk ${IWMMXT} ${LOONGSON_MMI} ${NEON}"
 EXTRA_OECONF_class-native = "--disable-gtk"
+EXTRA_OECONF_class-nativesdk = "--disable-gtk"
 
 SRC_URI += "\
             file://0001-ARM-qemu-related-workarounds-in-cpu-features-detecti.patch \
Signature · 1 line
1.9.1