ACPI / LPSS: change 'does not' to 'does' in comment
PATCH 1/1 ACPI / LPSS: change 'does not' to 'does' in comment
The LPSS DMA device does have neither _PS0 nor _PS3 method. Fix the wording in the comment line.
--- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +1 -1
@@ -95,7 +95,7 @@ static unsigned int lpss_quirks;/* * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA device. * -* The LPSS DMA controller does not have neither _PS0 nor _PS3 method. Moreover +* The LPSS DMA controller does have neither _PS0 nor _PS3 method. Moreover * it can be powered off automatically whenever the last LPSS device goes down. * In case of no power any access to the DMA controller will hang the system. * The behaviour is reproduced on some HP laptops based on Intel BayTrail as
Signature · 1 line
2.6.4
Quoted 13 lines · Andy Shevchenko
The LPSS DMA device does have neither
_PS0nor_PS3method. Fix the wording in the comment line.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/acpi_lpss.c +0
-0
drivers/acpi/acpi_lpss.c static unsigned int lpss_quirks; · line 98
Quoted 5 lines
drivers/acpi/acpi_lpss.c +1
-1@@ -95,7 +95,7 @@ static unsigned int lpss_quirks;/* * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA device. * -* The LPSS DMA controller does not have neither _PS0 nor _PS3 method. Moreover +* The LPSS DMA controller does have neither _PS0 nor _PS3 method. Moreover
Neither of the above are very clear. I think proper English would be:
The LPSS DMA controller has neither a _PS0 nor a _PS3 method.
or, alternatively:
The LPSS DMA controller does not have either a _PS0 or a _PS3 method.
This assumes that the point of the statement is to say that _PS0 and _PS3 methods do not exist for the LPSS DMA controller.
Quoted 4 lines
drivers/acpi/acpi_lpss.c +0
-0* it can be powered off automatically whenever the last LPSS device goes down. * In case of no power any access to the DMA controller will hang the system. * The behaviour is reproduced on some HP laptops based on Intel BayTrail as
Signature · 8 lines
ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. [email protected] -----------------------------------
Quoted 29 lines · Al Stone
Quoted 16 lines · Andy Shevchenko
The LPSS DMA device does have neither
_PS0nor_PS3method. Fix the wording in
the comment line.Signed-off-by Andy Shevchenko <[email protected]>---
drivers/acpi/acpi_lpss.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/acpi_lpss.c +0
-0@@ -95,7 +95,7 @@ static unsigned int lpss_quirks; /** LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA Quoted 6 lines
device.
*
- * The LPSS DMA controller does not have neither_PS0nor_PS3method. Moreover
+ * The LPSS DMA controller does have neither_PS0nor_PS3method. MoreoverNeither of the above are very clear. I think proper English would be:
The LPSS DMA controller has neither a
_PS0nor a_PS3method.
Quoted 8 lines
or, alternatively:
The LPSS DMA controller does not have either a
_PS0or a_PS3method.This assumes that the point of the statement is to say that
_PS0and_PS3
methods do not exist for the LPSS DMA controller.
Thanks! Will update this.
Quoted 10 lines
Quoted 8 lines
* it can be powered off automatically whenever the last LPSS device goes down.
* In case of no power any access to the DMA controller will hang the system.
* The behaviour is reproduced on some HP laptops based on Intel BayTrail as
Signature · 7 lines
Andy Shevchenko <[email protected]> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html