Skip to contentSkip to conversation

patch "coresight: checking for NULL string in coresight_name_match()" added to char-misc-next

PATCH [email protected] 1 participant 1 message Dec 22, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

coresight: checking for NULL string in coresight_name_match()

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-next branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will also be merged in the next major kernel release during the merge window.

If you have any questions about this process, please let me know.

Quoted 1 line

From fadf3a44e974b030e7145218ad1ab25e3ef91738 Mon Sep 17 00:00:00 2001

From: Mathieu Poirier <[email protected]>
Date: Thu, 17 Dec 2015 08:47:02 -0700
Subject: coresight: checking for NULL string in coresight_name_match()

Connection child names associated to ports can sometimes be NULL, which is the case when booting a system on QEMU or when the Coresight power domain isn't switched on.

This patch is adding a check to make sure a NULL string isn't fed to strcmp(), something that avoid crashing the system.

---
 drivers/hwtracing/coresight/coresight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/coresight/coresight.c +1 -1
index e25492137d8b..93738dfbf631 100644
@@ -548,7 +548,7 @@ static int coresight_name_match(struct device *dev, void *data)
 	to_match = data;
 	i_csdev = to_coresight_device(dev);
 
-	if (!strcmp(to_match, dev_name(&i_csdev->dev)))
+	if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev)))
 		return 1;
 
 	return 0;
Signature · 1 line
2.6.4