io: bind to loopback IP addrs in test suite
PATCH 1/1 io: bind to loopback IP addrs in test suite
The test suite currently binds to 0.0.0.0 or ::, which covers all interfaces of the machine. It is bad practice for test suite to open publically accessible ports on a machine, so switch to use loopback addrs 127.0.0.1 or ::1.
Reported-by Peter Maydell <[email protected]>
Signed-off-by Daniel P. Berrange <[email protected]>
--- tests/test-io-channel-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/test-io-channel-socket.c +2 -2
@@ -261,7 +261,7 @@ static void test_io_channel_ipv4(bool async) listen_addr->type =SOCKET_ADDRESS_KIND_INET ; listen_addr->u.inet =g_new0 (InetSocketAddress,1 ); - listen_addr->u.inet->host =g_strdup ("0.0.0.0" ); + listen_addr->u.inet->host =g_strdup ("127.0.0.1" ); listen_addr->u.inet->port =NULL ;/* Auto-select */ connect_addr->type =SOCKET_ADDRESS_KIND_INET ;
@@ -295,7 +295,7 @@ static void test_io_channel_ipv6(bool async) listen_addr->type =SOCKET_ADDRESS_KIND_INET ; listen_addr->u.inet =g_new0 (InetSocketAddress,1 ); - listen_addr->u.inet->host =g_strdup ("::" ); + listen_addr->u.inet->host =g_strdup ("::1" ); listen_addr->u.inet->port =NULL ;/* Auto-select */ connect_addr->type =SOCKET_ADDRESS_KIND_INET ;
Signature · 1 line
2.5.0
Quoted 10 lines · Daniel P. Berrange
The test suite currently binds to 0.0.0.0 or ::, which covers all interfaces of the machine. It is bad practice for test suite to open publically accessible ports on a machine, so switch to use loopback addrs 127.0.0.1 or ::1.
Reported-by Peter Maydell <[email protected]>Signed-off-by Daniel P. Berrange <[email protected]>--- tests/test-io-channel-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Eric Blake <[email protected]>
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org