Skip to contentSkip to conversation

Patch "ipv6: automatically enable stable privacy mode if stable_secret set" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Dec 31, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ipv6: automatically enable stable privacy mode if stable_secret set

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipv6-automatically-enable-stable-privacy-mode-if-stable_secret-set.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed Dec 30 19:52:45 PST 2015

From: Hannes Frederic Sowa <[email protected]>
Date: Tue, 15 Dec 2015 22:59:12 +0100
Subject: ipv6: automatically enable stable privacy mode if stable_secret set
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Hannes Frederic Sowa <[email protected]>

[ Upstream commit 9b29c6962b70f232cde4076b1020191e1be0889d ]

Bjørn reported that while we switch all interfaces to privacy stable mode when setting the secret, we don't set this mode for new interfaces. This does not make sense, so change this behaviour.

Fixes 622c81d57b392cc ("ipv6: generation of stable privacy addresses for link-local and autoconf")
Cc Bjørn Mork <[email protected]>
---
 net/ipv6/addrconf.c |    6 ++++++
 1 file changed, 6 insertions(+)
net/ipv6/addrconf.c +6 -0
@@ -343,6 +343,12 @@ static struct inet6_dev *ipv6_add_dev(st
 	setup_timer(&ndev->rs_timer, addrconf_rs_timer,
 		    (unsigned long)ndev);
 	memcpy(&ndev->cnf, dev_net(dev)->ipv6.devconf_dflt, sizeof(ndev->cnf));
+
+	if (ndev->cnf.stable_secret.initialized)
+		ndev->addr_gen_mode = IN6_ADDR_GEN_MODE_STABLE_PRIVACY;
+	else
+		ndev->addr_gen_mode = IN6_ADDR_GEN_MODE_EUI64;
+
 	ndev->cnf.mtu6 = dev->mtu;
 	ndev->cnf.sysctl = NULL;
 	ndev->nd_parms = neigh_parms_alloc(dev, &nd_tbl);

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/ipv6-automatically-enable-stable-privacy-mode-if-stable_secret-set.patch queue-4.1/af_unix-revert-lock_interruptible-in-stream-receive-code.patch queue-4.1/fou-clean-up-socket-with-kfree_rcu.patch queue-4.1/ipv6-keep-existing-flags-when-setting-ifa_f_optimistic.patch queue-4.1/net-add-validation-for-the-socket-syscall-protocol-argument.patch