Skip to contentSkip to conversation

Chromebook Keyboard LEDs

DISCUSSION Evan McClain 2 participants 2 messages Jan 2, 2016 – Jan 4, 2016 LED

lore
Share & tools
lore
#0 lore raw

Hi list,

I'm not sure how kosher it is to submit changes that I didn't author (cherry-picks from the chromium kernel), but since these patches are a few years old and having support in the mainline kernel would be nice I thought I'd give it a shot.

I have tested on my Chromebook Pixel 2 (samus) which runs fine but is missing a few drivers (this and ASoC, but ASoC isn't as easy).

The following changes since commit
376886d44f4cba72c4942aa1ac834ba00f6f222d:

  leds: bcm6358: remove unneeded busy status check (2015-12-17 09:39:02 +0100)

are available in the git repository at:

  https://github.com/aeroevan/linux.git for-leds

for you to fetch changes up to
589e241e11fa01a5fef59b40c9ad826e11322e4f:

  leds-chromeos-keyboard: Add ACPI _HID probing (2016-01-01 02:04:09 -0500)

----------------------------------------------------------------
Duncan Laurie (1):
      leds-chromeos-keyboard: Add ACPI _HID probing

Simon Que (3):
      leds: Add Chrome OS keyboard LEDs driver
      leds: chromeos keyboard name should contain "kbd_backlight"
      leds: Fix chromeos keyboard LED suspend behavior

 drivers/leds/Kconfig                  |   7 ++
 drivers/leds/Makefile                 |   1 +
 drivers/leds/leds-chromeos-keyboard.c | 127
++++++++++++++++++++++++++++++++++

 3 files changed, 135 insertions(+)

 create mode 100644 drivers/leds/leds-chromeos-keyboard.c

Thanks

Signature · 2 lines
Evan McClain
https://keybase.io/aeroevan
#1 lore raw

Hi Evan,

Please submit the driver officially, according to the rules stated in the Documentation/SubmittingPatches, so that we could discuss it. You'll also need to add your Signed-off-by tag.

Quoted 45 lines · Evan McClain

Hi list,

I'm not sure how kosher it is to submit changes that I didn't author (cherry-picks from the chromium kernel), but since these patches are a few years old and having support in the mainline kernel would be nice I thought I'd give it a shot.

I have tested on my Chromebook Pixel 2 (samus) which runs fine but is missing a few drivers (this and ASoC, but ASoC isn't as easy).

The following changes since commit
376886d44f4cba72c4942aa1ac834ba00f6f222d:

leds: bcm6358: remove unneeded busy status check (2015-12-17 09:39:02
+0100)

are available in the git repository at:

https://github.com/aeroevan/linux.git for-leds

for you to fetch changes up to
589e241e11fa01a5fef59b40c9ad826e11322e4f:

   leds-chromeos-keyboard: Add ACPI _HID probing (2016-01-01 02:04:09

-0500)

----------------------------------------------------------------
Duncan Laurie (1):
leds-chromeos-keyboard: Add ACPI _HID probing

Simon Que (3):
leds: Add Chrome OS keyboard LEDs driver
leds: chromeos keyboard name should contain "kbd_backlight"
leds: Fix chromeos keyboard LED suspend behavior

  drivers/leds/Kconfig                  |   7 ++
  drivers/leds/Makefile                 |   1 +
  drivers/leds/leds-chromeos-keyboard.c | 127
++++++++++++++++++++++++++++++++++
  3 files changed, 135 insertions(+)

create mode 100644 drivers/leds/leds-chromeos-keyboard.c

Thanks

Signature · 2 lines
Best Regards,
Jacek Anaszewski