Skip to contentSkip to conversation

tpm: remove unneeded include of actbl2.h

PATCH Applied Jerry Snitselaar 3 participants 4 messages Jan 4, 2016 – Jan 6, 2016 1 message not in the archive TPM device driver

lore
Share & tools
lore

Jerry Snitselaar

author
#0 lore raw

PATCH 1/1 tpm: remove unneeded include of actbl2.h

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed.

Signed-off-by Jerry Snitselaar <[email protected]>

---

Jarrko, this is a trivial thing I noticed while doing some work. Not sure if you guys care, but thought I'd send it in anyways.

 drivers/char/tpm/tpm_tis.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/tpm/tpm_tis.c +0 -1
index 65f7eec..461d486 100644
@@ -28,7 +28,6 @@
 #include <linux/wait.h>
 #include <linux/acpi.h>
 #include <linux/freezer.h>
-#include <acpi/actbl2.h>
 #include "tpm.h"
 
 enum tis_access {
Signature · 4 lines
2.6.1


------------------------------------------------------------------------------
author
#1 lore raw
Quoted 28 lines · Jerry Snitselaar

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed.

Signed-off-by Jerry Snitselaar <[email protected]>

---

Jarrko, this is a trivial thing I noticed while doing some work. Not sure if you guys care, but thought I'd send it in anyways.

drivers/char/tpm/tpm_tis.c | 1 -

1 file changed, 1 deletion(-)
drivers/char/tpm/tpm_tis.c +0 -1
index 65f7eec..461d486 100644
@@ -28,7 +28,6 @@
 #include <linux/wait.h>
 #include <linux/acpi.h>
 #include <linux/freezer.h>
-#include <acpi/actbl2.h>
 #include "tpm.h"
 
 enum tis_access {
Signature · 1 line
2.6.1

Not sure what happened, but it doesn't look like it CC'd Jarkko even though it shows it in the git send-email output. Adding the other maintainers as well.

	0001-tpm-remove-unneeded-include-of-actbl2.h.patch

	From: Jerry Snitselaar <[email protected]>
	To: [email protected]
	Cc: [email protected],
		[email protected]
	Subject: [PATCH] tpm: remove unneeded include of actbl2.h
	Date: Mon,  4 Jan 2016 12:19:43 -0700
	Message-Id: <[email protected]>
	X-Mailer: git-send-email 2.6.1

	Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
	OK. Log says:
	Server: smtp.corp.redhat.com
	MAIL FROM:<[email protected]>
	RCPT TO:<[email protected]>
	RCPT TO:<[email protected]>
	RCPT TO:<[email protected]>
	From: Jerry Snitselaar <[email protected]>
	To: [email protected]
	Cc: [email protected],
		[email protected]
	Subject: [PATCH] tpm: remove unneeded include of actbl2.h
	Date: Mon,  4 Jan 2016 12:19:43 -0700
	Message-Id: <[email protected]>
	X-Mailer: git-send-email 2.6.1

	Result: 250 2.0.0 u04JJkA6027832 Message accepted for delivery
Acked-by on v1 1/1
#2 lore raw
In reply to Jerry Snitselaar
Quoted 5 lines · Jerry Snitselaar

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed.

Signed-off-by Jerry Snitselaar <[email protected]>
Acked-by Jarkko Sakkinen <[email protected]>

/Jarkko

Quoted 23 lines

---

Jarrko, this is a trivial thing I noticed while doing some work. Not sure if you guys care, but thought I'd send it in anyways.

 drivers/char/tpm/tpm_tis.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/tpm/tpm_tis.c +0 -1
index 65f7eec..461d486 100644
@@ -28,7 +28,6 @@
 #include <linux/wait.h>
 #include <linux/acpi.h>
 #include <linux/freezer.h>
-#include <acpi/actbl2.h>
 #include "tpm.h"
 
 enum tis_access {
Signature · 1 line
2.6.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#4 lore raw
Quoted 8 lines · Jarkko Sakkinen
Quoted 5 lines · Jerry Snitselaar

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed.

Signed-off-by Jerry Snitselaar <[email protected]>
Acked-by Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/[email protected]>

Applied to https://github.com/jsakkine/linux-tpmdd/commits/master

/Jarkko

------------------------------------------------------------------------------