ASoC: pcm: allow delayed suspending request by users
PATCH 1/1 ASoC: pcm: allow delayed suspending request by users
From: Sanyog Kale <[email protected]>
If a device would like to use delayed suspending then PM recommendation is to set ‘power.use_autosuspend’ flag. To allow users to do so we need to change runtime calls in core to use autosuspend counterparts.
For user who do not wish to use delayed suspend not setting the device's ‘power.use_autosuspend’ flag will result in non-delayed suspend even with these APIs which incidentally is also the default behaviour, so only users will be impacted who opt in for this.
--- sound/soc/soc-pcm.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-)
sound/soc/soc-pcm.c +20 -8
@@ -599,10 +599,15 @@ platform_err: out:mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev);for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);
@@ -706,10 +711,17 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); + +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev); +for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);
Signature · 6 lines
1.9.1 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainerApplied "ASoC: pcm: allow delayed suspending request by users" to the asoc tree
The patch
ASoC: pcm: allow delayed suspending request by users
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
3f80978397f447973d278198e8bbde82826cb9c1Mon Sep 17 00:00:00 2001
From: Sanyog Kale <[email protected]>
Date: Tue, 5 Jan 2016 17:14:49 +0530
Subject: [PATCH] ASoC: pcm: allow delayed suspending request by users
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
If a device would like to use delayed suspending then PM recommendation is to set ‘power.use_autosuspend’ flag. To allow users to do so we need to change runtime calls in core to use autosuspend counterparts.
For user who do not wish to use delayed suspend not setting the device's ‘power.use_autosuspend’ flag will result in non-delayed suspend even with these APIs which incidentally is also the default behaviour, so only users will be impacted who opt in for this.
--- sound/soc/soc-pcm.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-)
sound/soc/soc-pcm.c +20 -8
@@ -599,10 +599,15 @@ platform_err: out:mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev);for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);
@@ -706,10 +711,17 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); + +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev); +for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);
Signature · 1 line
2.7.0.rc3
Quoted 55 lines · Vinod Koul
From: Sanyog Kale <[email protected]>
If a device would like to use delayed suspending then PM recommendation is to set ‘power.use_autosuspend’ flag. To allow users to do so we need to change runtime calls in core to use autosuspend counterparts.
For user who do not wish to use delayed suspend not setting the device's ‘power.use_autosuspend’ flag will result in non-delayed suspend even with these APIs which incidentally is also the default behaviour, so only users will be impacted who opt in for this.
Signed-off-by Sanyog Kale <[email protected]>Signed-off-by Vinod Koul <[email protected]>--- sound/soc/soc-pcm.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-)sound/soc/soc-pcm.c +13
-8@@ -599,10 +599,15 @@ platform_err: out:mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev);for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);@@ -706,10 +711,17 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)mutex_unlock (&rtd->pcm_mutex); -pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); + +for (i =0 ; i < rtd->num_codecs; i++) {
sound/soc/soc-pcm.c static int soc_pcm_close(struct snd_pcm_substream *substream) · line 727
Quoted 10 lines
sound/soc/soc-pcm.c +7
-0+pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } + +pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev); +for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);
Lots of duplicated codes there... Worth to have a common helper?
Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Vinod Koul
sound/soc/soc-pcm.c +8
-4-pm_runtime_put (platform->dev); -for (i =0 ; i < rtd->num_codecs; i++) -pm_runtime_put (rtd->codec_dais[i]->dev); -pm_runtime_put (cpu_dai->dev); +pm_runtime_mark_last_busy (platform->dev); +pm_runtime_put_autosuspend (platform->dev); + +for (i =0 ; i < rtd->num_codecs; i++) { +pm_runtime_mark_last_busy (rtd->codec_dais[i]->dev); +pm_runtime_put_autosuspend (rtd->codec_dais[i]->dev); + } +
Quoted 8 lines
sound/soc/soc-pcm.c static int soc_pcm_close(struct snd_pcm_substream *substream) · line 727
Quoted 6 lines
sound/soc/soc-pcm.c +3
-0+pm_runtime_mark_last_busy (cpu_dai->dev); +pm_runtime_put_autosuspend (cpu_dai->dev); +for (i =0 ; i < rtd->num_codecs; i++) {if (!rtd->codec_dais[i]->active)pinctrl_pm_select_sleep_state (rtd->codec_dais[i]->dev);Lots of duplicated codes there... Worth to have a common helper?
I certainly think so :) will do this after merge window
Signature · 1 line
~Vinod