drm/i915: shut up gen8+ SDE irq dmesg noise, again
Subsystems (2)
PATCH 1/1 drm/i915: shut up gen8+ SDE irq dmesg noise, again
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
This reverts
commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:23 2015 +0200
Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
Author: Daniel Vetter <[email protected]> Date: Fri Oct 23 10:56:12 2015 +0200
drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I did when I thought I'd fixed this for good in
commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:22 2015 +0200
drm/i915: fix the SDE irq dmesg warnings properly
Reference: http://mid.gmane.org/[email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
--- drivers/gpu/drm/i915/i915_irq.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +7 -3
@@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)spt_irq_handler (dev, pch_iir); elsecpt_irq_handler (dev ,pch_iir ); - }else -DRM_ERROR ("The master control interrupt lied (SDE)!\n" ); - + }else { +/* +* Like on previous PCH there seems to be something +* fishy going on with forwarding PCH interrupts. +*/ +DRM_DEBUG_DRIVER ("The master control interrupt lied (SDE)!\n" ); + } }I915_WRITE_FW (GEN8_MASTER_IRQ ,GEN8_MASTER_IRQ_CONTROL );
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 27 lines · Jani Nikula
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!This reverts
commit
820da7ae46332fa709b171eb7ba57cbd023fa6dfAuthor: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:23 2015 +0200Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit
97e5ed1111dcc5300a0f59a55248cd243937a8abAuthor: Daniel Vetter <[email protected]> Date: Fri Oct 23 10:56:12 2015 +0200drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I did when I thought I'd fixed this for good in
commit
6a39d7c986be4fd18eb019e9cdbf774ec36c9f77Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:22 2015 +0200
Quoted 8 lines
drm/i915: fix the SDE irq dmesg warnings properly
Reported-by Chris Wilson <[email protected]>Reference: http://mid.gmane.org/[email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084Fixes 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")Signed-off-by Jani Nikula <[email protected]>
(still not convinced that even a debug error message gives us any insight over and above mmio tracing)
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 27 lines · Jani Nikula
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!This reverts
commit
820da7ae46332fa709b171eb7ba57cbd023fa6dfAuthor: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:23 2015 +0200Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit
97e5ed1111dcc5300a0f59a55248cd243937a8abAuthor: Daniel Vetter <[email protected]> Date: Fri Oct 23 10:56:12 2015 +0200drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I did when I thought I'd fixed this for good in
commit
6a39d7c986be4fd18eb019e9cdbf774ec36c9f77Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:22 2015 +0200
Quoted 8 lines
drm/i915: fix the SDE irq dmesg warnings properly
Reported-by Chris Wilson <[email protected]>Reference: http://mid.gmane.org/[email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084Fixes 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")Signed-off-by Jani Nikula <[email protected]>
Oh well, agreed it's time to give up :(
Quoted 32 lines
--- drivers/gpu/drm/i915/i915_irq.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_irq.c +7
-3@@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)spt_irq_handler (dev, pch_iir); elsecpt_irq_handler (dev ,pch_iir ); - }else -DRM_ERROR ("The master control interrupt lied (SDE)!\n" ); - + }else { +/* +* Like on previous PCH there seems to be something +* fishy going on with forwarding PCH interrupts. +*/ +DRM_DEBUG_DRIVER ("The master control interrupt lied (SDE)!\n" ); + } }I915_WRITE_FW (GEN8_MASTER_IRQ ,GEN8_MASTER_IRQ_CONTROL );Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 37 lines · Daniel Vetter
Quoted 27 lines · Jani Nikula
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!This reverts
commit
820da7ae46332fa709b171eb7ba57cbd023fa6dfAuthor: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:23 2015 +0200Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit
97e5ed1111dcc5300a0f59a55248cd243937a8abAuthor: Daniel Vetter <[email protected]> Date: Fri Oct 23 10:56:12 2015 +0200drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I did when I thought I'd fixed this for good in
commit
6a39d7c986be4fd18eb019e9cdbf774ec36c9f77Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:22 2015 +0200Quoted 8 lines
drm/i915: fix the SDE irq dmesg warnings properly
Reported-by Chris Wilson <[email protected]>Reference: http://mid.gmane.org/[email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084Fixes 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")Signed-off-by Jani Nikula <[email protected]>
Quoted 3 lines
Oh well, agreed it's time to give up :(
Acked-by Daniel Vetter <[email protected]>
Thanks, pushed to drm-intel-next-queued.
BR,
Jani.
Quoted 32 lines
Quoted 32 lines
--- drivers/gpu/drm/i915/i915_irq.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_irq.c +7
-3@@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)spt_irq_handler (dev, pch_iir); elsecpt_irq_handler (dev ,pch_iir ); - }else -DRM_ERROR ("The master control interrupt lied (SDE)!\n" ); - + }else { +/* +* Like on previous PCH there seems to be something +* fishy going on with forwarding PCH interrupts. +*/ +DRM_DEBUG_DRIVER ("The master control interrupt lied (SDE)!\n" ); + } }I915_WRITE_FW (GEN8_MASTER_IRQ ,GEN8_MASTER_IRQ_CONTROL );Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 38 lines · Jani Nikula
Quoted 37 lines · Daniel Vetter
Quoted 35 lines · Jani Nikula
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!This reverts
commit
820da7ae46332fa709b171eb7ba57cbd023fa6dfAuthor: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:23 2015 +0200Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit
97e5ed1111dcc5300a0f59a55248cd243937a8abAuthor: Daniel Vetter <[email protected]> Date: Fri Oct 23 10:56:12 2015 +0200drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I did when I thought I'd fixed this for good in
commit
6a39d7c986be4fd18eb019e9cdbf774ec36c9f77Author: Jani Nikula <[email protected]> Date: Wed Nov 25 16:47:22 2015 +0200drm/i915: fix the SDE irq dmesg warnings properly
Reported-by Chris Wilson <[email protected]>Reference: http://mid.gmane.org/[email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084Fixes 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")Signed-off-by Jani Nikula <[email protected]>
Quoted 5 lines
Quoted 3 lines
Oh well, agreed it's time to give up :(
Acked-by Daniel Vetter <[email protected]>Thanks, pushed to drm-intel-next-queued.
Given people still see this on 4.3.y and what will soon be 4.4 final, which is a long term stable release, should it be CC'd to stable?
josh
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx