perf config: Rename 'colors.code' to 'colors.jump_arrows'
PATCH v2 1/1 perf config: Rename 'colors.code' to 'colors.jump_arrows'
Suggest 'jump_arrows' config name instead of 'code' on 'colors' section. 'colors.code' config is only for jump arrows on assembly code listings i.e.
│ ┌──jmp 1333
│ │ xchg %ax,%ax
│ │ mov %r15,%r10
│ └─→cmp %r15,%r14But this config name seems unfit.
Maybe 'jump_arrows' would be better than 'code'.
Cc Namhyung Kim <[email protected]>
Cc Jiri Olsa <[email protected]>
Signed-off-by Taeung Song <[email protected]>
--- tools/perf/Documentation/perf-config.txt | 2 +- tools/perf/Documentation/perfconfig.example | 2 +- tools/perf/ui/browser.c | 4 ++-- tools/perf/ui/browser.h | 2 +- tools/perf/ui/browsers/annotate.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
tools/perf/Documentation/perf-config.txt +1 -1
@@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this: medium = green, default normal = lightgray, default selected = white, lightgray - code = blue, default + jump_arrows = blue, default addr = magenta, default root = white, blue
tools/perf/Documentation/perfconfig.example +1 -1
@@ -5,7 +5,7 @@ medium = green, lightgray normal = black, lightgray selected = lightgray, magenta - code = blue, lightgray + jump_arrows = blue, lightgray addr = magenta, lightgray [tui]
tools/perf/ui/browser.c +2 -2
@@ -531,8 +531,8 @@ static struct ui_browser_colorset { .bg = "yellow", }, { - .colorset = HE_COLORSET_CODE, - .name = "code", + .colorset = HE_COLORSET_JUMP_ARROWS, + .name = "jump_arrows", .fg = "blue", .bg = "default", },
tools/perf/ui/browser.h +1 -1
@@ -7,7 +7,7 @@#define HE_COLORSET_MEDIUM 51#define HE_COLORSET_NORMAL 52#define HE_COLORSET_SELECTED 53 -#define HE_COLORSET_CODE 54 +#define HE_COLORSET_JUMP_ARROWS 54#define HE_COLORSET_ADDR 55#define HE_COLORSET_ROOT 56
tools/perf/ui/browsers/annotate.c +1 -1
@@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) to = (u64 )btarget->idx; } -ui_browser__set_color (browser,HE_COLORSET_CODE ); +ui_browser__set_color (browser,HE_COLORSET_JUMP_ARROWS );__ui_browser__line_arrow (browser, pcnt_width +2 + ab->addr_width, from, to); }
Signature · 1 line
2.5.0
tip-bot for Taeung Song
merge bot[tip:perf/core] perf annotate: Rename 'colors.code' to ' colors.jump_arrows'
perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
Commit-ID: 78ce08dfbd180fb85312ee76e607a6c5fe34a06c Gitweb: http://git.kernel.org/tip/78ce08dfbd180fb85312ee76e607a6c5fe34a06c Author: Taeung Song <[email protected]> AuthorDate: Fri, 8 Jan 2016 17:16:11 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 26 Jan 2016 11:52:46 -0300
perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
USe 'jump_arrows' config name instead of 'code' on 'colors' section. 'colors.code' config is only for jump arrows on assembly code listings i.e.
│ ┌──jmp 1333
│ │ xchg %ax,%ax
│ │ mov %r15,%r10
│ └─→cmp %r15,%r14But this config name seems unfit.
'jump_arrows' is more descriptive than 'code'.
Signed-off-by Taeung Song <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/Documentation/perf-config.txt | 2 +- tools/perf/Documentation/perfconfig.example | 2 +- tools/perf/ui/browser.c | 4 ++-- tools/perf/ui/browser.h | 2 +- tools/perf/ui/browsers/annotate.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
tools/perf/Documentation/perf-config.txt +1 -1
@@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this: medium = green, default normal = lightgray, default selected = white, lightgray - code = blue, default + jump_arrows = blue, default addr = magenta, default root = white, blue
tools/perf/Documentation/perfconfig.example +1 -1
@@ -5,7 +5,7 @@ medium = green, lightgray normal = black, lightgray selected = lightgray, magenta - code = blue, lightgray + jump_arrows = blue, lightgray addr = magenta, lightgray [tui]
tools/perf/ui/browser.c +2 -2
@@ -531,8 +531,8 @@ static struct ui_browser_colorset { .bg = "yellow", }, { - .colorset = HE_COLORSET_CODE, - .name = "code", + .colorset = HE_COLORSET_JUMP_ARROWS, + .name = "jump_arrows", .fg = "blue", .bg = "default", },
tools/perf/ui/browser.h +1 -1
@@ -7,7 +7,7 @@#define HE_COLORSET_MEDIUM 51#define HE_COLORSET_NORMAL 52#define HE_COLORSET_SELECTED 53 -#define HE_COLORSET_CODE 54 +#define HE_COLORSET_JUMP_ARROWS 54#define HE_COLORSET_ADDR 55#define HE_COLORSET_ROOT 56
tools/perf/ui/browsers/annotate.c +1 -1
@@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) to = (u64 )btarget->idx; } -ui_browser__set_color (browser,HE_COLORSET_CODE ); +ui_browser__set_color (browser,HE_COLORSET_JUMP_ARROWS );__ui_browser__line_arrow (browser, pcnt_width +2 + ab->addr_width, from, to); }