Skip to contentSkip to conversation

Add attr build dependency

PATCH In review Scott Ellis 2 participants 6 messages Jan 14, 2016 – Jan 15, 2016

lore
Share & tools
lore

Scott Ellis

author
#0 lore raw

PATCH 1/1 Add attr build dependency

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>
---
 meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
 LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                     file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp libcap"
 DEPENDS_class-native = ""
 
 inherit autotools gettext texinfo

--
2.5.0

#1 lore raw

Scott

Thanks for patch. You might want to send into to oe-core mailing list.

Quoted 19 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"

LICENSE = "GPLv3+"

LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                    file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"

meta/recipes-core/coreutils/coreutils_8.24.bb

Quoted 2 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp lib cap”

while this fix is good. We can make this into a packageconfig knob

PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"

Quoted 11 lines

DEPENDS_class-native = ""

inherit autotools gettext texinfo
--
2.5.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

author
#2 lore raw

The 'something' would be 'xattr'

PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"

What should the default be?

The acl option for coreutils looks in DISTRO_FEATURES.

Should I do the same for this?

Quoted 45 lines · Khem Raj

Scott

Thanks for patch. You might want to send into to oe-core mailing list.

Quoted 21 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"

LICENSE = "GPLv3+"

LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                    file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"

meta/recipes-core/coreutils/coreutils_8.24.bb

Quoted 2 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp lib cap”

while this fix is good. We can make this into a packageconfig knob

PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"

Quoted 11 lines

DEPENDS_class-native = ""

inherit autotools gettext texinfo
--
2.5.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#3 lore raw
Quoted 12 lines · Scott Ellis

The 'something' would be 'xattr'

PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"

What should the default be?

The acl option for coreutils looks in DISTRO_FEATURES.

Should I do the same for this?

if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the packageconfig and then weakly assign a default with ??=

Quoted 55 lines
Quoted 30 lines · Khem Raj

Scott

Thanks for patch. You might want to send into to oe-core mailing list.

Quoted 21 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"

LICENSE = "GPLv3+"

LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                   file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"

meta/recipes-core/coreutils/coreutils_8.24.bb

Quoted 2 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp lib cap”

while this fix is good. We can make this into a packageconfig knob

Quoted 15 lines

PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"

Quoted 11 lines

DEPENDS_class-native = ""

inherit autotools gettext texinfo
--
2.5.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

author
#4 lore raw

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>
---
 meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +7 -2
index f042346..6a09c59 100644
@@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
 EXTRA_OECONF_class-native = "--without-gmp"
 EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"
 
-# acl is not a default feature
+# acl and xattr are not default features
 #
-PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-target ??= "\
+    ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
+"
+
 PACKAGECONFIG_class-native ??= ""
 
 # with, without, depends, rdepends
 #
 PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
+PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
 
 # [ df mktemp base64 gets a special treatment and is not included in this
 bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \

--
2.5.0

Quoted 74 lines · Khem Raj
Quoted 12 lines · Scott Ellis

The 'something' would be 'xattr'

PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"

What should the default be?

The acl option for coreutils looks in DISTRO_FEATURES.

Should I do the same for this?

if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the packageconfig
and then weakly assign a default with ??=

Quoted 55 lines
Quoted 30 lines · Khem Raj

Scott

Thanks for patch. You might want to send into to oe-core mailing list.

Quoted 21 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"

LICENSE = "GPLv3+"

LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                   file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"

meta/recipes-core/coreutils/coreutils_8.24.bb

Quoted 2 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp lib cap”

while this fix is good. We can make this into a packageconfig knob

Quoted 15 lines

PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"

Quoted 11 lines

DEPENDS_class-native = ""

inherit autotools gettext texinfo
--
2.5.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#5 lore raw
Quoted 23 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--

1 file changed, 7 insertions(+), 2 deletions(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..6a09c59 100644
@@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc

EXTRA_OECONF_class-native = "--without-gmp"
EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"

meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-# acl is not a default feature
+# acl and xattr are not default features

#

meta/recipes-core/coreutils/coreutils_8.24.bb SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc

Quoted 5 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +4 -1
-PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-target ??= "\
+    ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
+”

Thanks, this one looks good.

Quoted 97 lines

+

PACKAGECONFIG_class-native ??= ""

# with, without, depends, rdepends
#
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl," +PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"

# [ df mktemp base64 gets a special treatment and is not included in this bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
--
2.5.0

Quoted 9 lines · Khem Raj
Quoted 9 lines · Scott Ellis

The 'something' would be 'xattr'

PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"

What should the default be?

Quoted 65 lines
Quoted 3 lines

The acl option for coreutils looks in DISTRO_FEATURES.

Should I do the same for this?

if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the packageconfig
and then weakly assign a default with ??=

Quoted 55 lines
Quoted 30 lines · Khem Raj

Scott

Thanks for patch. You might want to send into to oe-core mailing list.

Quoted 21 lines · Scott Ellis

Fixes this warning:

WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]

Signed-off-by Scott Ellis <[email protected]>

---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.24.bb +0 -0
index f042346..47a25f3 100644
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"

LICENSE = "GPLv3+"

LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
                  file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"

meta/recipes-core/coreutils/coreutils_8.24.bb

Quoted 2 lines
meta/recipes-core/coreutils/coreutils_8.24.bb +1 -1
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp lib cap”

while this fix is good. We can make this into a packageconfig knob

Quoted 15 lines

PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"

Quoted 11 lines

DEPENDS_class-native = ""

inherit autotools gettext texinfo
--
2.5.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto