Skip to contentSkip to conversation

iommu/vt-d: Don't skip PCI devices when disabling IOTLB

PATCH Applied Jeremy McNicoll 3 participants 3 messages Jan 15, 2016 – Jan 29, 2016 1 message not in the archive IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/vt-d: Don't skip PCI devices when disabling IOTLB

Fix a simple typo when disabling IOTLB on PCI(e) devices.

Fixes b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI capabilities before ATS")
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +1 -1
index ac73876..986a53e 100644
@@ -1489,7 +1489,7 @@ static void iommu_disable_dev_iotlb(struct device_domain_info *info)
 {
 	struct pci_dev *pdev;
 
-	if (dev_is_pci(info->dev))
+	if (!dev_is_pci(info->dev))
 		return;
 
 	pdev = to_pci_dev(info->dev);
Signature · 1 line
2.6.1

A message that is not in the archive (sent off-list or not yet received): 1452835986-8731-1-git-send-email-jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 21 lines · Jeremy McNicoll

Fix a simple typo when disabling IOTLB on PCI(e) devices.

Fixes b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI

capabilities before ATS")

---
 drivers/iommu/intel-iommu.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel- renamed from drivers/iommu/intel-iommu.c +0 -0

iommu.c
index ac73876..986a53e 100644

drivers/iommu/intel-iommu.c +0 -0
@@ -1489,7 +1489,7 @@ static void iommu_disable_dev_iotlb(struct
 device_domain_info *info)
  {
  	struct pci_dev *pdev;

drivers/iommu/intel-iommu.c +1 -1
-	if (dev_is_pci(info->dev))
+	if (!dev_is_pci(info->dev))
Quoted 3 lines

  return;

  pdev = to_pci_dev(info->dev);

Looks like a pretty obvious typo/thinko to me.  I'd probably suggest it for v4.4 stable too.

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu