drm/i915: Do not put big intel_crtc_state on the stack
Subsystems (2)
PATCH 1/1 drm/i915: Do not put big intel_crtc_state on the stack
From: Tvrtko Ursulin <[email protected]>
Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway.
This required a little bit of refactoring to handle the new failure path from vlv_force_pll_on.
---
Compile tested only!
--- drivers/gpu/drm/i915/intel_display.c | 58 +++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_dp.c | 8 +++-- drivers/gpu/drm/i915/intel_drv.h | 4 +-- 3 files changed, 45 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/intel_display.c +37 -21
@@ -7635,26 +7635,34 @@ static void chv_prepare_pll(struct intel_crtc *crtc,* in cases where we need the PLL enabled even when @pipe is not going to * be enabled. */ -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe,const struct dpll *dpll) {struct intel_crtc *crtc =to_intel_crtc (intel_get_crtc_for_pipe (dev, pipe)); -struct intel_crtc_state pipe_config = { - .base.crtc = &crtc->base, - .pixel_multiplier =1 , - .dpll = *dpll, - }; +struct intel_crtc_state *pipe_config; + + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) +return -ENOMEM ; + + pipe_config->base.crtc = &crtc->base; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll = *dpll;if (IS_CHERRYVIEW (dev)) { -chv_compute_dpll (crtc, &pipe_config); -chv_prepare_pll (crtc, &pipe_config); -chv_enable_pll (crtc, &pipe_config); +chv_compute_dpll (crtc, pipe_config); +chv_prepare_pll (crtc, pipe_config); +chv_enable_pll (crtc, pipe_config); }else { -vlv_compute_dpll (crtc, &pipe_config); -vlv_prepare_pll (crtc, &pipe_config); -vlv_enable_pll (crtc, &pipe_config); +vlv_compute_dpll (crtc, pipe_config); +vlv_prepare_pll (crtc, pipe_config); +vlv_enable_pll (crtc, pipe_config); } + +kfree (pipe_config); + +return 0 ; }/**
@@ -10828,7 +10836,7 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,struct intel_crtc *intel_crtc =to_intel_crtc (crtc);enum transcoder cpu_transcoder = intel_crtc->config->cpu_transcoder;struct drm_display_mode *mode; -struct intel_crtc_state pipe_config; +struct intel_crtc_state *pipe_config;int htot =I915_READ (HTOTAL (cpu_transcoder));int hsync =I915_READ (HSYNC (cpu_transcoder));int vtot =I915_READ (VTOTAL (cpu_transcoder));
@@ -10839,6 +10847,12 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,if (!mode)return NULL ; + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) { +kfree (mode); +return NULL ; + } +/* * Construct a pipe_config sufficient for getting the clock info * back out of crtc_clock_get.
@@ -10846,14 +10860,14 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,* Note, if LVDS ever uses a non-1 pixel multiplier, we'll need * to use a real value here instead. */ - pipe_config.cpu_transcoder = (enum transcoder ) pipe; - pipe_config.pixel_multiplier =1 ; - pipe_config.dpll_hw_state.dpll =I915_READ (DPLL (pipe)); - pipe_config.dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); - pipe_config.dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); -i9xx_crtc_clock_get (intel_crtc, &pipe_config); - - mode->clock = pipe_config.port_clock / pipe_config.pixel_multiplier; + pipe_config->cpu_transcoder = (enum transcoder ) pipe; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll_hw_state.dpll =I915_READ (DPLL (pipe)); + pipe_config->dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); + pipe_config->dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); +i9xx_crtc_clock_get (intel_crtc, pipe_config); + + mode->clock = pipe_config->port_clock / pipe_config->pixel_multiplier; mode->hdisplay = (htot &0xffff ) +1 ; mode->htotal = ((htot &0xffff0000 ) >>16 ) +1 ; mode->hsync_start = (hsync &0xffff ) +1 ;
@@ -10865,6 +10879,8 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,drm_mode_set_name (mode); +kfree (pipe_config); +return mode; }
drivers/gpu/drm/i915/intel_dp.c +6 -2
@@ -335,8 +335,12 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) release_cl_override =IS_CHERRYVIEW (dev) && !chv_phy_powergate_ch (dev_priv, phy, ch, true); -vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? - &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll); +if (vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? + &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll)) { +DRM_ERROR ("Failed to force on pll for pipe %c!\n" , +pipe_name (pipe)); +return ; + } }/*
drivers/gpu/drm/i915/intel_drv.h +2 -2
@@ -1177,8 +1177,8 @@ void assert_shared_dpll(struct drm_i915_private *dev_priv,struct intel_shared_dpll *intel_get_shared_dpll (struct intel_crtc *crtc,struct intel_crtc_state *state); -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, -const struct dpll *dpll); +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +const struct dpll *dpll);void vlv_force_pll_off (struct drm_device *dev,enum pipe pipe);/* modesetting asserts */
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Do not put big intel_crtc_state on the stack
== Summary ==
== Summary ==
Built on 20c388faff9d8c41ab27e825c685526561b892a2 drm-intel-nightly: 2016y-01m-19d-13h-31m-46s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
pass -> DMESG-WARN (bdw-nuci7) UNSTABLE
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b:
pass -> SKIP (bdw-nuci7)bdw-nuci7 total:140 pass:129 dwarn:1 dfail:0 fail:0 skip:10 bsw-nuc-2 total:143 pass:117 dwarn:2 dfail:0 fail:0 skip:24 byt-nuc total:143 pass:125 dwarn:3 dfail:0 fail:0 skip:15 hsw-brixbox total:143 pass:136 dwarn:0 dfail:0 fail:0 skip:7 hsw-gt2 total:143 pass:139 dwarn:0 dfail:0 fail:0 skip:4 ilk-hp8440p total:143 pass:102 dwarn:3 dfail:0 fail:0 skip:38 skl-i5k-2 total:143 pass:133 dwarn:2 dfail:0 fail:0 skip:8 snb-dellxps total:143 pass:124 dwarn:5 dfail:0 fail:0 skip:14 snb-x220t total:143 pass:124 dwarn:5 dfail:0 fail:1 skip:13
Results at /archive/results/CI_IGT_test/Patchwork_1223/
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 34 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway.
This required a little bit of refactoring to handle the new failure path from
vlv_force_pll_on.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Daniel Vetter <[email protected]>Cc John Harrison <[email protected]>Cc Ville Syrjälä <[email protected]>---
Compile tested only!--- drivers/gpu/drm/i915/intel_display.c | 58 +++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_dp.c | 8 +++-- drivers/gpu/drm/i915/intel_drv.h | 4 +-- 3 files changed, 45 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/intel_display.c +1
-1@@ -7635,26 +7635,34 @@ static void chv_prepare_pll(struct intel_crtc *crtc,* in cases where we need the PLL enabled even when @pipe is not going to * be enabled. */ -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe,const struct dpll *dpll) {struct intel_crtc *crtc =to_intel_crtc (intel_get_crtc_for_pipe (dev, pipe));
drivers/gpu/drm/i915/intel_display.c static void chv_prepare_pll(struct intel_crtc *crtc, · line 7647
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +5
-5-struct intel_crtc_state pipe_config = { - .base.crtc = &crtc->base, - .pixel_multiplier =1 , - .dpll = *dpll, - }; +struct intel_crtc_state *pipe_config; + + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) +return -ENOMEM ;
tbh I wouldn't bother with the return code here since the only caller can't do anything about it anyway. But since this is a bit a bikeshed, either way:
Quoted 118 lines
drivers/gpu/drm/i915/intel_display.c +31
-15+ + pipe_config->base.crtc = &crtc->base; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll = *dpll;if (IS_CHERRYVIEW (dev)) { -chv_compute_dpll (crtc, &pipe_config); -chv_prepare_pll (crtc, &pipe_config); -chv_enable_pll (crtc, &pipe_config); +chv_compute_dpll (crtc, pipe_config); +chv_prepare_pll (crtc, pipe_config); +chv_enable_pll (crtc, pipe_config); }else { -vlv_compute_dpll (crtc, &pipe_config); -vlv_prepare_pll (crtc, &pipe_config); -vlv_enable_pll (crtc, &pipe_config); +vlv_compute_dpll (crtc, pipe_config); +vlv_prepare_pll (crtc, pipe_config); +vlv_enable_pll (crtc, pipe_config); } + +kfree (pipe_config); + +return 0 ; }/** @@ -10828,7 +10836,7 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,struct intel_crtc *intel_crtc =to_intel_crtc (crtc);enum transcoder cpu_transcoder = intel_crtc->config->cpu_transcoder;struct drm_display_mode *mode; -struct intel_crtc_state pipe_config; +struct intel_crtc_state *pipe_config;int htot =I915_READ (HTOTAL (cpu_transcoder));int hsync =I915_READ (HSYNC (cpu_transcoder));int vtot =I915_READ (VTOTAL (cpu_transcoder));@@ -10839,6 +10847,12 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,if (!mode)return NULL ; + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) { +kfree (mode); +return NULL ; + } +/* * Construct a pipe_config sufficient for getting the clock info * back out of crtc_clock_get. @@ -10846,14 +10860,14 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,* Note, if LVDS ever uses a non-1 pixel multiplier, we'll need * to use a real value here instead. */ - pipe_config.cpu_transcoder = (enum transcoder ) pipe; - pipe_config.pixel_multiplier =1 ; - pipe_config.dpll_hw_state.dpll =I915_READ (DPLL (pipe)); - pipe_config.dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); - pipe_config.dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); -i9xx_crtc_clock_get (intel_crtc, &pipe_config); - - mode->clock = pipe_config.port_clock / pipe_config.pixel_multiplier; + pipe_config->cpu_transcoder = (enum transcoder ) pipe; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll_hw_state.dpll =I915_READ (DPLL (pipe)); + pipe_config->dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); + pipe_config->dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); +i9xx_crtc_clock_get (intel_crtc, pipe_config); + + mode->clock = pipe_config->port_clock / pipe_config->pixel_multiplier; mode->hdisplay = (htot &0xffff ) +1 ; mode->htotal = ((htot &0xffff0000 ) >>16 ) +1 ; mode->hsync_start = (hsync &0xffff ) +1 ;@@ -10865,6 +10879,8 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,drm_mode_set_name (mode); +kfree (pipe_config); +return mode; }drivers/gpu/drm/i915/intel_dp.c +6
-2@@ -335,8 +335,12 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) release_cl_override =IS_CHERRYVIEW (dev) && !chv_phy_powergate_ch (dev_priv, phy, ch, true); -vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? - &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll); +if (vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? + &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll)) { +DRM_ERROR ("Failed to force on pll for pipe %c!\n" , +pipe_name (pipe)); +return ; + } }/* drivers/gpu/drm/i915/intel_drv.h +2
-2@@ -1177,8 +1177,8 @@ void assert_shared_dpll(struct drm_i915_private *dev_priv,struct intel_shared_dpll *intel_get_shared_dpll (struct intel_crtc *crtc,struct intel_crtc_state *state); -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, -const struct dpll *dpll); +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +const struct dpll *dpll);void vlv_force_pll_off (struct drm_device *dev,enum pipe pipe);/* modesetting asserts */ Signature · 1 line
1.9.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 50 lines · Daniel Vetter
Quoted 34 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway.
This required a little bit of refactoring to handle the new failure path from
vlv_force_pll_on.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Daniel Vetter <[email protected]>Cc John Harrison <[email protected]>Cc Ville Syrjälä <[email protected]>---
Compile tested only!--- drivers/gpu/drm/i915/intel_display.c | 58 +++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_dp.c | 8 +++-- drivers/gpu/drm/i915/intel_drv.h | 4 +-- 3 files changed, 45 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/intel_display.c +1
-1@@ -7635,26 +7635,34 @@ static void chv_prepare_pll(struct intel_crtc *crtc,* in cases where we need the PLL enabled even when @pipe is not going to * be enabled. */ -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe,const struct dpll *dpll) {struct intel_crtc *crtc =to_intel_crtc (intel_get_crtc_for_pipe (dev, pipe));drivers/gpu/drm/i915/intel_display.c static void chv_prepare_pll(struct intel_crtc *crtc, · line 7647
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +5
-5-struct intel_crtc_state pipe_config = { - .base.crtc = &crtc->base, - .pixel_multiplier =1 , - .dpll = *dpll, - }; +struct intel_crtc_state *pipe_config; + + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) +return -ENOMEM ;tbh I wouldn't bother with the return code here since the only caller can't do anything about it anyway. But since this is a bit a bikeshed, either way:
Quoted 1 line
Reviewed-by Daniel Vetter <[email protected]>
Thanks!
First version actually did not bother with returning the error, but then I thought someone will be guaranteed to complain. :)
If it had more than one caller there would be some value in being able to report the error closer to the callsite, but like this is as you say.
However, being one of the rare patches which got a CI success I did not want to risk that and just merged it like it is. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 81 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway.
This required a little bit of refactoring to handle the new failure path from
vlv_force_pll_on.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Daniel Vetter <[email protected]>Cc John Harrison <[email protected]>Cc Ville Syrjälä <[email protected]>---
Compile tested only!--- drivers/gpu/drm/i915/intel_display.c | 58 +++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_dp.c | 8 +++-- drivers/gpu/drm/i915/intel_drv.h | 4 +-- 3 files changed, 45 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/intel_display.c +21
-13@@ -7635,26 +7635,34 @@ static void chv_prepare_pll(struct intel_crtc *crtc,* in cases where we need the PLL enabled even when @pipe is not going to * be enabled. */ -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe,const struct dpll *dpll) {struct intel_crtc *crtc =to_intel_crtc (intel_get_crtc_for_pipe (dev, pipe)); -struct intel_crtc_state pipe_config = { - .base.crtc = &crtc->base, - .pixel_multiplier =1 , - .dpll = *dpll, - }; +struct intel_crtc_state *pipe_config; + + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL ); +if (!pipe_config) +return -ENOMEM ; + + pipe_config->base.crtc = &crtc->base; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll = *dpll;if (IS_CHERRYVIEW (dev)) { -chv_compute_dpll (crtc, &pipe_config); -chv_prepare_pll (crtc, &pipe_config); -chv_enable_pll (crtc, &pipe_config); +chv_compute_dpll (crtc, pipe_config); +chv_prepare_pll (crtc, pipe_config); +chv_enable_pll (crtc, pipe_config); }else { -vlv_compute_dpll (crtc, &pipe_config); -vlv_prepare_pll (crtc, &pipe_config); -vlv_enable_pll (crtc, &pipe_config); +vlv_compute_dpll (crtc, pipe_config); +vlv_prepare_pll (crtc, pipe_config); +vlv_enable_pll (crtc, pipe_config); } + +kfree (pipe_config); + +return 0 ; }/** @@ -10828,7 +10836,7 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,struct intel_crtc *intel_crtc =to_intel_crtc (crtc);enum transcoder cpu_transcoder = intel_crtc->config->cpu_transcoder;struct drm_display_mode *mode; -struct intel_crtc_state pipe_config; +struct intel_crtc_state *pipe_config;int htot =I915_READ (HTOTAL (cpu_transcoder));int hsync =I915_READ (HSYNC (cpu_transcoder));int vtot =I915_READ (VTOTAL (cpu_transcoder));
drivers/gpu/drm/i915/intel_display.c struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev, · line 10850
Quoted 4 lines
drivers/gpu/drm/i915/intel_display.c +1
-0@@ -10839,6 +10847,12 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,if (!mode)return NULL ; + pipe_config =kzalloc (sizeof (*pipe_config),GFP_KERNEL );
GFP_TEMPORARY
BR,
Jani.
Quoted 74 lines
drivers/gpu/drm/i915/intel_display.c +15
-8+if (!pipe_config) { +kfree (mode); +return NULL ; + } +/* * Construct a pipe_config sufficient for getting the clock info * back out of crtc_clock_get. @@ -10846,14 +10860,14 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,* Note, if LVDS ever uses a non-1 pixel multiplier, we'll need * to use a real value here instead. */ - pipe_config.cpu_transcoder = (enum transcoder ) pipe; - pipe_config.pixel_multiplier =1 ; - pipe_config.dpll_hw_state.dpll =I915_READ (DPLL (pipe)); - pipe_config.dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); - pipe_config.dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); -i9xx_crtc_clock_get (intel_crtc, &pipe_config); - - mode->clock = pipe_config.port_clock / pipe_config.pixel_multiplier; + pipe_config->cpu_transcoder = (enum transcoder ) pipe; + pipe_config->pixel_multiplier =1 ; + pipe_config->dpll_hw_state.dpll =I915_READ (DPLL (pipe)); + pipe_config->dpll_hw_state.fp0 =I915_READ (FP0 (pipe)); + pipe_config->dpll_hw_state.fp1 =I915_READ (FP1 (pipe)); +i9xx_crtc_clock_get (intel_crtc, pipe_config); + + mode->clock = pipe_config->port_clock / pipe_config->pixel_multiplier; mode->hdisplay = (htot &0xffff ) +1 ; mode->htotal = ((htot &0xffff0000 ) >>16 ) +1 ; mode->hsync_start = (hsync &0xffff ) +1 ;@@ -10865,6 +10879,8 @@ struct drm_display_mode *intel_crtc_mode_get(struct drm_device *dev,drm_mode_set_name (mode); +kfree (pipe_config); +return mode; }drivers/gpu/drm/i915/intel_dp.c +6
-2@@ -335,8 +335,12 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) release_cl_override =IS_CHERRYVIEW (dev) && !chv_phy_powergate_ch (dev_priv, phy, ch, true); -vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? - &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll); +if (vlv_force_pll_on (dev, pipe,IS_CHERRYVIEW (dev) ? + &chv_dpll[0 ].dpll : &vlv_dpll[0 ].dpll)) { +DRM_ERROR ("Failed to force on pll for pipe %c!\n" , +pipe_name (pipe)); +return ; + } }/* drivers/gpu/drm/i915/intel_drv.h +2
-2@@ -1177,8 +1177,8 @@ void assert_shared_dpll(struct drm_i915_private *dev_priv,struct intel_shared_dpll *intel_get_shared_dpll (struct intel_crtc *crtc,struct intel_crtc_state *state); -void vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, -const struct dpll *dpll); +int vlv_force_pll_on (struct drm_device *dev,enum pipe pipe, +const struct dpll *dpll);void vlv_force_pll_off (struct drm_device *dev,enum pipe pipe);/* modesetting asserts */
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx