Skip to contentSkip to conversation

ASoC: rk3036: fix missing dependency on REGMAP_MMIO

PATCH In review Antonio Ospite 2 participants 2 messages Jan 25, 2016 – Jan 27, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rk3036: fix missing dependency on REGMAP_MMIO

When SND_SOC_INNO_RK3036 is enabled but REGMAP_MMIO is not, the MODPOST step fails with this error:

...
Kernel: arch/x86/boot/bzImage is ready (#3)
Building modules, stage 2.
MODPOST 3203 modules
ERROR: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-inno-rk3036.ko] undefined!

Cc ZhengShunQian <[email protected]>
Cc Mark Brown <[email protected]>

---

Hi,

I enabled SND_SOC_INNO_RK3036 by chance in 4.5-rc1 and the build failed. The patch below allows the kernel to be configured in a buildable way.

Ciao ciao,
Antonio

 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/Kconfig +1 -0
index 50693c8..1f7eaa9 100644
@@ -497,6 +497,7 @@ config SND_SOC_ICS43432
 
 config SND_SOC_INNO_RK3036
 	tristate "Inno codec driver for RK3036 SoC"
+	select REGMAP_MMIO
 
 config SND_SOC_ISABELLE
         tristate
Signature · 1 line
2.7.0
maintainer
#1 lore raw

Applied "ASoC: rk3036: fix missing dependency on REGMAP_MMIO" to the asoc tree

The patch

ASoC: rk3036: fix missing dependency on REGMAP_MMIO

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 7315917f7ccdf5eb5758f663a781daa7599d63d7 Mon Sep 17 00:00:00 2001

From: Antonio Ospite <[email protected]>
Date: Mon, 25 Jan 2016 18:23:30 +0100
Subject: [PATCH] ASoC: rk3036: fix missing dependency on REGMAP_MMIO

When SND_SOC_INNO_RK3036 is enabled but REGMAP_MMIO is not, the MODPOST step fails with this error:

...
Kernel: arch/x86/boot/bzImage is ready (#3)
Building modules, stage 2.
MODPOST 3203 modules
ERROR: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-inno-rk3036.ko] undefined!

---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/Kconfig +1 -0
index 50693c867e71..1f7eaa919088 100644
@@ -497,6 +497,7 @@ config SND_SOC_ICS43432
 
 config SND_SOC_INNO_RK3036
 	tristate "Inno codec driver for RK3036 SoC"
+	select REGMAP_MMIO
 
 config SND_SOC_ISABELLE
         tristate
Signature · 1 line
2.7.0.rc3