Skip to contentSkip to conversation

Patch "ALSA: seq: Fix missing NULL check at remove_events ioctl" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jan 26, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: seq: Fix missing NULL check at remove_events ioctl

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 030e2c78d3a91dd0d27fef37e91950dde333eba1 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Tue, 12 Jan 2016 12:38:02 +0100
Subject: ALSA: seq: Fix missing NULL check at remove_events ioctl

From: Takashi Iwai <[email protected]>

commit 030e2c78d3a91dd0d27fef37e91950dde333eba1 upstream.

snd_seq_ioctl_remove_events() calls snd_seq_fifo_clear() unconditionally even if there is no FIFO assigned, and this leads to an Oops due to NULL dereference. The fix is just to add a proper NULL check.

---
 sound/core/seq/seq_clientmgr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/seq/seq_clientmgr.c +1 -1
@@ -1962,7 +1962,7 @@ static int snd_seq_ioctl_remove_events(s
 		 * No restrictions so for a user client we can clear
 		 * the whole fifo
 		 */
-		if (client->type == USER_CLIENT)
+		if (client->type == USER_CLIENT && client->data.user.fifo)
 			snd_seq_fifo_clear(client->data.user.fifo);
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-hrtimer-fix-stall-by-hrtimer_cancel.patch queue-4.4/alsa-hda-fix-white-noise-on-dell-latitude-e5550.patch queue-4.4/alsa-hda-fix-the-headset-mic-detection-problem-for-a-dell-laptop.patch queue-4.4/alsa-timer-harden-slave-timer-list-handling.patch queue-4.4/alsa-timer-fix-double-unlink-of-active_list.patch queue-4.4/alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch queue-4.4/alsa-hda-flush-the-pending-probe-work-at-remove.patch queue-4.4/alsa-hda-fixup-inverted-internal-mic-for-lenovo-e50-80.patch queue-4.4/alsa-usb-add-native-dsd-support-for-oppo-ha-1.patch queue-4.4/alsa-hda-fix-missing-module-loading-with-model-generic-option.patch queue-4.4/alsa-seq-fix-race-at-timer-setup-and-close.patch queue-4.4/alsa-pcm-fix-snd_pcm_hw_params-struct-copy-in-compat-mode.patch queue-4.4/alsa-seq-fix-snd_seq_call_port_info_ioctl-in-compat-mode.patch queue-4.4/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch queue-4.4/alsa-usb-audio-fix-mixer-ctl-regression-of-native-instrument-devices.patch queue-4.4/alsa-timer-handle-disconnection-more-safely.patch queue-4.4/alsa-hda-fix-bass-pin-fixup-for-asus-n550jx.patch queue-4.4/alsa-timer-fix-race-among-timer-ioctls.patch queue-4.4/alsa-hda-add-fixup-for-dell-latitidue-e6540.patch queue-4.4/alsa-usb-audio-avoid-calling-usb_autopm_put_interface-at-disconnect.patch