Skip to contentSkip to conversation

Patch "USB: ipaq.c: fix a timeout loop" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jan 26, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: ipaq.c: fix a timeout loop

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-ipaq.c-fix-a-timeout-loop.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From abdc9a3b4bac97add99e1d77dc6d28623afe682b Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 16 Dec 2015 14:06:37 +0300
Subject: USB: ipaq.c: fix a timeout loop

From: Dan Carpenter <[email protected]>

commit abdc9a3b4bac97add99e1d77dc6d28623afe682b upstream.

The code expects the loop to end with "retries" set to zero but, because it is a post-op, it will end set to -1. I have fixed this by moving the decrement inside the loop.

Fixes 014aa2a3c32e ('USB: ipaq: minor ipaq_open() cleanup.')
---
 drivers/usb/serial/ipaq.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/ipaq.c +2 -1
@@ -531,7 +531,8 @@ static int ipaq_open(struct tty_struct *
 	 * through. Since this has a reasonably high failure rate, we retry
 	 * several times.
 	 */
-	while (retries--) {
+	while (retries) {
+		retries--;
 		result = usb_control_msg(serial->dev,
 				usb_sndctrlpipe(serial->dev, 0), 0x22, 0x21,
 				0x1, 0, NULL, 0, 100);

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/usb-ipaq.c-fix-a-timeout-loop.patch queue-4.1/x86-mpx-fix-instruction-decoder-condition.patch