Skip to contentSkip to conversation

ASoC: imx-spdif: Fix crash on suspend

PATCH New Lars-Peter Clausen 1 participant 1 message Jan 26, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: imx-spdif: Fix crash on suspend

When registering a ASoC card the driver data of the parent device is set to point to the card. This driver data is used in the snd_soc_suspend()/resume() callbacks.

The imx-spdif driver overwrites the driver data with custom data which causes snd_soc_suspend() to crash. Since the custom driver is not used anywhere simply deleting the line which sets the custom driver data fixes the issue.

Fixes 43ac946922b3 ("ASoC: imx-spdif: add snd_soc_pm_ops for spdif machine driver")
---
 sound/soc/fsl/imx-spdif.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/fsl/imx-spdif.c +0 -2
index a407e83..fb896b2 100644
@@ -72,8 +72,6 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
 		goto end;
 	}
 
-	platform_set_drvdata(pdev, data);
-
 end:
 	of_node_put(spdif_np);
 
Signature · 1 line
2.1.4