Skip to contentSkip to conversation

Fixes and improvements to f_fs and f_midi

PATCH In review Michal Nazarewicz 4 participants 5 messages Jan 26, 2016 – Feb 19, 2016

lore
Share & tools
lore
#0 lore raw

v3 cover Fixes and improvements to f_fs and f_midi

Resending my previous two sets for f_fs and f_midi. This time rebased on top of Felipe’s next branch.

Dan Carpenter (1):
usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
usb: gadget: f_midi: remove useless midi reference from port struct

Michal Nazarewicz (8):
usb: f_fs: fix memory leak when ep changes during transfer
usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
usb: f_fs: replace unnecessary goto with a return
usb: f_fs: refactor ffs_epfile_io
usb: gadget: f_midi: move some of f_midi_transmit to separate func
usb: gadget: f_midi: fix in_last_port looping logic
usb: gadget: f_midi: use flexible array member for gmidi_in_port
elements
usb: gadget: f_midi: stash substream in gmidi_in_port structure

 drivers/usb/gadget/function/f_fs.c   | 155 +++++++++++++--------------
 drivers/usb/gadget/function/f_midi.c | 200 ++++++++++++++++-------------------
 2 files changed, 164 insertions(+), 191 deletions(-)
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#1 lore raw

Hi Michal,

Quoted 12 lines · Michal Nazarewicz

Resending my previous two sets for f_fs and f_midi. This time rebased on top of Felipe’s next branch.

Dan Carpenter (1):
usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
usb: gadget: f_midi: remove useless midi reference from port struct

Quoted 10 lines

Michal Nazarewicz (8):
usb: f_fs: fix memory leak when ep changes during transfer
usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
usb: f_fs: replace unnecessary goto with a return
usb: f_fs: refactor ffs_epfile_io
usb: gadget: f_midi: move some of f_midi_transmit to separate func
usb: gadget: f_midi: fix in_last_port looping logic
usb: gadget: f_midi: use flexible array member for gmidi_in_port
elements
usb: gadget: f_midi: stash substream in gmidi_in_port structure

Sorry for the delay, but I will look into your patches related to f_midi this week.

Quoted 5 lines
 drivers/usb/gadget/function/f_fs.c   | 155 +++++++++++++--------------
 drivers/usb/gadget/function/f_midi.c | 200 ++++++++++++++++-------------------
 2 files changed, 164 insertions(+), 191 deletions(-)
Signature · 1 line
Felipe
#2 lore raw
In reply to Michal Nazarewicz

Hi,

Quoted 12 lines · Michal Nazarewicz

Resending my previous two sets for f_fs and f_midi. This time rebased on top of Felipe’s next branch.

Dan Carpenter (1):
usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
usb: gadget: f_midi: remove useless midi reference from port struct

Quoted 10 lines

Michal Nazarewicz (8):
usb: f_fs: fix memory leak when ep changes during transfer
usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
usb: f_fs: replace unnecessary goto with a return
usb: f_fs: refactor ffs_epfile_io
usb: gadget: f_midi: move some of f_midi_transmit to separate func
usb: gadget: f_midi: fix in_last_port looping logic
usb: gadget: f_midi: use flexible array member for gmidi_in_port
elements
usb: gadget: f_midi: stash substream in gmidi_in_port structure

looks like I don't have these patches in my inbox, care to resend ?

thanks

Signature · 1 line
balbi
#3 lore raw
Quoted 23 lines
Quoted 22 lines · Michal Nazarewicz

Resending my previous two sets for f_fs and f_midi. This time rebased on top of Felipe’s next branch.

Dan Carpenter (1):
usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
usb: gadget: f_midi: remove useless midi reference from port struct

Michal Nazarewicz (8):
usb: f_fs: fix memory leak when ep changes during transfer
usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
usb: f_fs: replace unnecessary goto with a return
usb: f_fs: refactor ffs_epfile_io
usb: gadget: f_midi: move some of f_midi_transmit to separate func
usb: gadget: f_midi: fix in_last_port looping logic
usb: gadget: f_midi: use flexible array member for gmidi_in_port
elements
usb: gadget: f_midi: stash substream in gmidi_in_port structure

Quoted 1 line · Felipe Balbi

looks like I don't have these patches in my inbox, care to resend ?

Patches freshly rebased on your next branch coming right up. Also available at:

git fetch https://github.com/mina86/linux.git for-felipe

Signature · 3 lines
Best regards
Liege of Serenely Enlightened Majesty of Computer Science,
ミハウ “mina86” ナザレヴイツ  <[email protected]> <xmpp:[email protected]>
#4 lore raw

Hi,

Quoted 24 lines · Michal Nazarewicz
Quoted 13 lines
Quoted 12 lines · Michal Nazarewicz

Resending my previous two sets for f_fs and f_midi. This time rebased on top of Felipe’s next branch.

Dan Carpenter (1):
usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
usb: gadget: f_midi: remove useless midi reference from port struct

Quoted 10 lines
Quoted 10 lines

Michal Nazarewicz (8):
usb: f_fs: fix memory leak when ep changes during transfer
usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
usb: f_fs: replace unnecessary goto with a return
usb: f_fs: refactor ffs_epfile_io
usb: gadget: f_midi: move some of f_midi_transmit to separate func
usb: gadget: f_midi: fix in_last_port looping logic
usb: gadget: f_midi: use flexible array member for gmidi_in_port
elements
usb: gadget: f_midi: stash substream in gmidi_in_port structure

Quoted 7 lines
Quoted 1 line · Felipe Balbi

looks like I don't have these patches in my inbox, care to resend ?

Patches freshly rebased on your next branch coming right up. Also available at:

git fetch https://github.com/mina86/linux.git for-felipe

thanks, I'll fetch your branch and apply the patches individually :-)

Signature · 1 line
balbi