Skip to contentSkip to conversation

hwmon: (it87) Various enhancements and fixes

PATCH In review Guenter Roeck 4 participants 8 messages Jan 27, 2016 – Apr 12, 2016 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

v3 cover hwmon: (it87) Various enhancements and fixes

From: Guenter Roeck <[email protected]>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

Most of the patches in this series were previously submitted as part of earlier patch series. No substantial changes were made to those patches since the previous submission.

----------------------------------------------------------------
Guenter Roeck (25):
hwmon: (it87) Add feature flag for AVCC3 support
hwmon: (it87) Add support for all pwm channels on IT8620E
hwmon: (it87) Add support for second pwm frequency register
hwmon: (it87) Simplify error return in it87_device_add
hwmon: (it87) Don't use pdev as static driver variable
hwmon: (it87) Pass SIO base address as parameter to superio functions
hwmon: (it87) Add support for second Super-IO chip
hwmon: (it87) Rearrange code to avoid forward declarations
hwmon: (it87) Use is_visible for voltage sensors
hwmon: (it87) Use is_visible for temperature sensors
hwmon: (it87) Use is_visible for fan attributes
hwmon: (it87) Use is_visible for pwm attributes
hwmon: (it87) Use single group and is_visible for miscellaneous attributes
hwmon: (it87) Convert to use new hwmon API
hwmon: (it87) Support up to 6 temperature sensors on IT8620E
hwmon: (it87) Simplify reading voltage registers
hwmon: (it87) Add support for VIN7 to VIN10 on IT8620E
hwmon: (it87) Use BIT macro
hwmon: (it87) Use defines for array sizes and sensor counts
hwmon: (it87) Formatting cleanup
hwmon: (it87) Support disabling fan control for all pwm control and chips
hwmon: (it87) Enhance validation for fan4 and fan5
hwmon: (it87) Support automatic pwm control on newer chips
hwmon: (it87) Fix pwm_temp_map for system with 6 pwm channels
hwmon: (it87) Add support for IT8628E

 Documentation/hwmon/it87 |   15 +-
 drivers/hwmon/Kconfig    |    3 +-
 drivers/hwmon/it87.c     | 2281 ++++++++++++++++++++++++++--------------------
 3 files changed, 1300 insertions(+), 999 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

maintainer
#1 lore raw
Quoted 10 lines · Guenter Roeck

From: Guenter Roeck <[email protected]>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

Most of the patches in this series were previously submitted as part of earlier patch series. No substantial changes were made to those patches since the previous submission.

Jean,

Any idea what to do with this series ?

Guenter

Quoted 28 lines

----------------------------------------------------------------
Guenter Roeck (25):
hwmon: (it87) Add feature flag for AVCC3 support
hwmon: (it87) Add support for all pwm channels on IT8620E
hwmon: (it87) Add support for second pwm frequency register
hwmon: (it87) Simplify error return in it87_device_add
hwmon: (it87) Don't use pdev as static driver variable
hwmon: (it87) Pass SIO base address as parameter to superio functions
hwmon: (it87) Add support for second Super-IO chip
hwmon: (it87) Rearrange code to avoid forward declarations
hwmon: (it87) Use is_visible for voltage sensors
hwmon: (it87) Use is_visible for temperature sensors
hwmon: (it87) Use is_visible for fan attributes
hwmon: (it87) Use is_visible for pwm attributes
hwmon: (it87) Use single group and is_visible for miscellaneous attributes
hwmon: (it87) Convert to use new hwmon API
hwmon: (it87) Support up to 6 temperature sensors on IT8620E
hwmon: (it87) Simplify reading voltage registers
hwmon: (it87) Add support for VIN7 to VIN10 on IT8620E
hwmon: (it87) Use BIT macro
hwmon: (it87) Use defines for array sizes and sensor counts
hwmon: (it87) Formatting cleanup
hwmon: (it87) Support disabling fan control for all pwm control and chips
hwmon: (it87) Enhance validation for fan4 and fan5
hwmon: (it87) Support automatic pwm control on newer chips
hwmon: (it87) Fix pwm_temp_map for system with 6 pwm channels
hwmon: (it87) Add support for IT8628E

Quoted 5 lines
  Documentation/hwmon/it87 |   15 +-
  drivers/hwmon/Kconfig    |    3 +-
  drivers/hwmon/it87.c     | 2281 ++++++++++++++++++++++++++--------------------
  3 files changed, 1300 insertions(+), 999 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

maintainer
#2 lore raw
In reply to Guenter Roeck
Quoted 10 lines · Guenter Roeck

From: Guenter Roeck <[email protected]>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

Most of the patches in this series were previously submitted as part of earlier patch series. No substantial changes were made to those patches since the previous submission.

Jean,

any idea what to do with this patch series ?

Guenter

Quoted 28 lines

----------------------------------------------------------------
Guenter Roeck (25):
hwmon: (it87) Add feature flag for AVCC3 support
hwmon: (it87) Add support for all pwm channels on IT8620E
hwmon: (it87) Add support for second pwm frequency register
hwmon: (it87) Simplify error return in it87_device_add
hwmon: (it87) Don't use pdev as static driver variable
hwmon: (it87) Pass SIO base address as parameter to superio functions
hwmon: (it87) Add support for second Super-IO chip
hwmon: (it87) Rearrange code to avoid forward declarations
hwmon: (it87) Use is_visible for voltage sensors
hwmon: (it87) Use is_visible for temperature sensors
hwmon: (it87) Use is_visible for fan attributes
hwmon: (it87) Use is_visible for pwm attributes
hwmon: (it87) Use single group and is_visible for miscellaneous attributes
hwmon: (it87) Convert to use new hwmon API
hwmon: (it87) Support up to 6 temperature sensors on IT8620E
hwmon: (it87) Simplify reading voltage registers
hwmon: (it87) Add support for VIN7 to VIN10 on IT8620E
hwmon: (it87) Use BIT macro
hwmon: (it87) Use defines for array sizes and sensor counts
hwmon: (it87) Formatting cleanup
hwmon: (it87) Support disabling fan control for all pwm control and chips
hwmon: (it87) Enhance validation for fan4 and fan5
hwmon: (it87) Support automatic pwm control on newer chips
hwmon: (it87) Fix pwm_temp_map for system with 6 pwm channels
hwmon: (it87) Add support for IT8628E

Quoted 5 lines
  Documentation/hwmon/it87 |   15 +-
  drivers/hwmon/Kconfig    |    3 +-
  drivers/hwmon/it87.c     | 2281 ++++++++++++++++++++++++++--------------------
  3 files changed, 1300 insertions(+), 999 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw

Re: [lm-sensors] [PATCH v3 00/25] hwmon: (it87) V

Quoted 5 lines · Guenter Roeck <patchwork <at> patchwork.roeck-us.net> writes:

From: Guenter Roeck <linux <at> roeck-us.net>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

I've been running the whole series on top of v4.5 for the past two weeks on a system with IT8628E. I did not find any problems so far.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

maintainer
#4 lore raw

Hi Martin,

Quoted 9 lines · Martin Blumenstingl
Quoted 5 lines · Guenter Roeck <patchwork <at> patchwork.roeck-us.net> writes:

From: Guenter Roeck <linux <at> roeck-us.net>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

I've been running the whole series on top of v4.5 for the past two weeks on a system with IT8628E. I did not find any problems so far.

thanks a lot for the feedback. It would be great if you can send me an official Tested-by: that I can add into the series (or a permission to do so).

With the experience gained with the off-list driver, I think this series is good to go for upstream, even without code review feedback. Otherwise I fear we'll never get there. Jean, any objections ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#5 lore raw
Quoted 11 lines · Guenter Roeck
Quoted 7 lines
Quoted 3 lines

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

I've been running the whole series on top of v4.5 for the past two weeks on a system with IT8628E. I did not find any problems so far.

thanks a lot for the feedback. It would be great if you can send me an official Tested-by: that I can add into the series (or a permission to do so).

sure, feel free to add this to the whole series:

PS: Thank you Guenter for your hard work on this!

#6 lore raw
In reply to Guenter Roeck

Hi Guenter,

Quoted 12 lines · Guenter Roeck

Hi Martin,

Quoted 8 lines · Martin Blumenstingl
Quoted 5 lines · Guenter Roeck <patchwork <at> patchwork.roeck-us.net> writes:

From: Guenter Roeck <linux <at> roeck-us.net>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

I've been running the whole series on top of v4.5 for the past two weeks on a system with IT8628E. I did not find any problems so far.

Quoted 7 lines

thanks a lot for the feedback. It would be great if you can send me an official Tested-by: that I can add into the series (or a permission to do so).

With the experience gained with the off-list driver, I think this series is good to go for upstream, even without code review feedback. Otherwise I fear we'll never get there. Jean, any objections ?

I am sorry that I do not have the time to review this patch series. But I trust your judgment and I have no objection, if you think the series is good to go upstream then please push it there.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer
#7 lore raw
Quoted 19 lines · Jean Delvare

Hi Guenter,

Quoted 16 lines · Guenter Roeck

Hi Martin,

Quoted 8 lines · Martin Blumenstingl
Quoted 5 lines · Guenter Roeck <patchwork <at> patchwork.roeck-us.net> writes:

From: Guenter Roeck <linux <at> roeck-us.net>

This patch series builds on top of v4.5-rc1. The series was tested on a system with IT8728F. Out-of-kernel versions were tested by various people using a github repository.

I've been running the whole series on top of v4.5 for the past two weeks on a system with IT8628E. I did not find any problems so far.

thanks a lot for the feedback. It would be great if you can send me an official Tested-by: that I can add into the series (or a permission to do so).

Quoted 8 lines
Quoted 3 lines

With the experience gained with the off-list driver, I think this series is good to go for upstream, even without code review feedback. Otherwise I fear we'll never get there. Jean, any objections ?

I am sorry that I do not have the time to review this patch series. But I trust your judgment and I have no objection, if you think the series is good to go upstream then please push it there.

No need to be sorry. We are all busy.

Thanks!
Guenter