Skip to contentSkip to conversation

Add debugger entry points for AVR32

PATCH In review Jeffrey Merkey 2 participants 3 messages Jan 28, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 3/31 Add debugger entry points for AVR32

This patch series adds an export which can be set by system debuggers to direct the hard lockup and soft lockup detector to trigger a breakpoint exception and enter a debugger if one is active. It is assumed that if someone sets this variable, then an breakpoint handler of some sort will be actively loaded or registered via the notify die handler chain.

This addition is extremely useful for debugging hard and soft lockups real time and quickly from a console debugger.

---
 arch/avr32/include/asm/kdebug.h | 4 ++++
 1 file changed, 4 insertions(+)
arch/avr32/include/asm/kdebug.h +4 -0
index f930ce2..f67caf0 100644
@@ -1,6 +1,10 @@
 #ifndef __ASM_AVR32_KDEBUG_H
 #define __ASM_AVR32_KDEBUG_H
 
+static inline void arch_breakpoint(void)
+{
+}
+
 /* Grossly misnamed. */
 enum die_val {
 	DIE_BREAKPOINT,
Signature · 1 line
1.8.3.1
Acked-by on v1 3/31
#1 lore raw
Quoted 10 lines · Jeffrey Merkey

This patch series adds an export which can be set by system debuggers to direct the hard lockup and soft lockup detector to trigger a breakpoint exception and enter a debugger if one is active. It is assumed that if someone sets this variable, then an breakpoint handler of some sort will be actively loaded or registered via the notify die handler chain.

This addition is extremely useful for debugging hard and soft lockups real time and quickly from a console debugger.

Quoted 9 lines
---
 arch/avr32/include/asm/kdebug.h | 4 ++++
 1 file changed, 4 insertions(+)
arch/avr32/include/asm/kdebug.h +0 -0
index f930ce2..f67caf0 100644

arch/avr32/include/asm/kdebug.h line 6

Quoted 6 lines
arch/avr32/include/asm/kdebug.h +3 -0
@@ -1,6 +1,10 @@
 #ifndef __ASM_AVR32_KDEBUG_H
 #define __ASM_AVR32_KDEBUG_H
 
+static inline void arch_breakpoint(void)
+{
+}

Will not this just be optimized away? Are you expecting other developers to add a no-op assembler instruction into this function body?

<snipp>

Signature · 1 line
Best regards, Hans-Christian Egtvedt
#2 lore raw
Quoted 34 lines · Hans-Christian Noren Egtvedt
Quoted 10 lines · Jeffrey Merkey

This patch series adds an export which can be set by system debuggers to direct the hard lockup and soft lockup detector to trigger a breakpoint exception and enter a debugger if one is active. It is assumed that if someone sets this variable, then an breakpoint handler of some sort will be actively loaded or registered via the notify die handler chain.

This addition is extremely useful for debugging hard and soft lockups real time and quickly from a console debugger.

Quoted 10 lines
---
 arch/avr32/include/asm/kdebug.h | 4 ++++
 1 file changed, 4 insertions(+)
arch/avr32/include/asm/kdebug.h +0 -0
index f930ce2..f67caf0 100644

arch/avr32/include/asm/kdebug.h line 6

Quoted 6 lines
arch/avr32/include/asm/kdebug.h +3 -0
@@ -1,6 +1,10 @@
 #ifndef __ASM_AVR32_KDEBUG_H
 #define __ASM_AVR32_KDEBUG_H
 
+static inline void arch_breakpoint(void)
+{
+}

Will not this just be optimized away? Are you expecting other developers to add a no-op assembler instruction into this function body?

Quoted 4 lines

<snipp>
--
Best regards, Hans-Christian Egtvedt

Yes, I am hoping the maintainers of each arch to make a decision about how they wish to implement this and/or change it. Totally up to you guys. I need it stubbed in all the arches so it passes test robot builds for watchdog.c.

Jeff