Skip to contentSkip to conversation

Add debugger entry points for TILE

PATCH In review Jeffrey Merkey 2 participants 2 messages Jan 28, 2016

lore
Share & tools
lore

Jeffrey Merkey

author
#0 lore raw

PATCH 9/31 Add debugger entry points for TILE

This patch series adds an export which can be set by system debuggers to direct the hard lockup and soft lockup detector to trigger a breakpoint exception and enter a debugger if one is active. It is assumed that if someone sets this variable, then an breakpoint handler of some sort will be actively loaded or registered via the notify die handler chain.

This addition is extremely useful for debugging hard and soft lockups real time and quickly from a console debugger.

Signed-off-by Jeffrey Merkey <[email protected]>
---
 arch/tile/include/asm/kdebug.h | 6 ++++++
 1 file changed, 6 insertions(+)
arch/tile/include/asm/kdebug.h +6 -0
index 5bbbfa9..b6f556a 100644
@@ -25,4 +25,10 @@ enum die_val {
 	DIE_COMPILED_BPT
 };
 
+static inline void arch_breakpoint(void)
+{
+	asm volatile (".quad %0\n\t"
+		      ::""(compiled_bpt));
+}
+
 #endif /* _ASM_TILE_KDEBUG_H */
Signature · 1 line
1.8.3.1
build bot
#1 lore raw
reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree…

Hi Jeffrey,

[auto build test ERROR on v4.5-rc1]
[also build test ERROR on next-20160128]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Jeffrey-Merkey/Add-hard-soft-lockup-debugger-entry-points/20160129-035852
config: tile-tilegx_defconfig (attached as .config)

reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile

All errors (new ones prefixed by >>):

In file included from include/linux/kdebug.h:4:0,

                    from arch/tile/include/asm/kgdb.h:20,
                    from include/linux/kgdb.h:20,
                    from mm/highmem.c:29:
   arch/tile/include/asm/kdebug.h: In function 'arch_breakpoint':
>> arch/tile/include/asm/kdebug.h:31:14: error: 'compiled_bpt' undeclared (first use in this function)

arch/tile/include/asm/kdebug.h:31:14: note: each undeclared identifier is reported only once for each function it appears in

vim +/compiled_bpt +31 arch/tile/include/asm/kdebug.h

    25		DIE_COMPILED_BPT
    26	};
    27	
    28	static inline void arch_breakpoint(void)
    29	{
    30		asm volatile (".quad %0\n\t"
  > 31			      ::""(compiled_bpt));
    32	}
    33	
    34	#endif /* _ASM_TILE_KDEBUG_H */

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation