patch "Staging: speakup: Fix getting port information" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
Staging: speakup: Fix getting port information
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
327b882d3bcc1fba82dbd39b5cf5a838c81218e2Mon Sep 17 00:00:00 2001
From: Samuel Thibault <[email protected]>
Date: Fri, 15 Jan 2016 00:47:41 +0100
Subject: Staging: speakup: Fix getting port information
Commit f79b0d9c223c ("staging: speakup: Fixed warning <linux/serial.h> instead of <asm/serial.h>") broke the port information in the speakup
driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, and no other header includes asm/serial.h.
We here make sure serialio.c does get the arch-specific definition of SERIAL_PORT_DFNS from asm/serial.h, if any.
Along the way, this makes sure that we do have information for the requested serial port number (index)
--- drivers/staging/speakup/serialio.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/staging/speakup/serialio.c +12 -1
@@ -6,6 +6,11 @@#include "spk_priv.h" #include "serialio.h" +#include <linux/serial_core.h> +/* WARNING: Do not change this to <linux/serial.h> without testing that +* SERIAL_PORT_DFNS does get defined to the appropriate value. */ +#include <asm/serial.h> +#ifndef SERIAL_PORT_DFNS #define SERIAL_PORT_DFNS #endif
@@ -23,9 +28,15 @@ const struct old_serial_port *spk_serial_init(int index)int baud =9600 , quot =0 ;unsigned int cval =0 ;int cflag =CREAD |HUPCL |CLOCAL |B9600 |CS8 ; -const struct old_serial_port *ser = rs_table + index; +const struct old_serial_port *ser;int err; +if (index >=ARRAY_SIZE (rs_table)) { +pr_info ("no port info for ttyS%d\n" , index); +return NULL ; + } + ser = rs_table + index; +/* Divisor, bytesize and parity */ quot = ser->baud_base / baud; cval = cflag & (CSIZE |CSTOPB );
Signature · 1 line
2.7.0