patch "iio:adc:ti_am335x_adc Fix buffered mode by identifying as software" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio:adc:ti_am335x_adc Fix buffered mode by identifying as software
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
9d0be85d4e2cfa2519ae16efe7ff4a7150c43c0bMon Sep 17 00:00:00 2001
From: Jonathan Cameron <[email protected]>
Date: Fri, 1 Jan 2016 18:05:34 +0000
Subject: iio:adc:ti_am335x_adc Fix buffered mode by identifying as software
buffer.
Whilst this part has a hardware buffer, the identifcation that IIO cares about is the userspace facing end. It this case we push individual elements from the hardware fifo into the software interface (specifically a kfifo) rather than providing direct reads through to a hardware buffer (as we still do in the sca3000 for example).
Technically the original specification as a hardware buffer could be considered wrong, but it didn't matter until the patch listed below.
Result is that any attempt to enable the buffer will return -EINVAL
--- drivers/iio/adc/ti_am335x_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti_am335x_adc.c +1 -1
@@ -289,7 +289,7 @@ static int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev, goto error_kfifo_free; indio_dev->setup_ops = setup_ops; - indio_dev->modes |=INDIO_BUFFER_HARDWARE ; + indio_dev->modes |=INDIO_BUFFER_SOFTWARE ;return 0 ;
Signature · 1 line
2.7.0