Patch "dm btree: fix leak of bufio-backed block in btree_split_sibling error path" has been added to the 3.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
dm btree: fix leak of bufio-backed block in btree_split_sibling error path
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dm-btree-fix-leak-of-bufio-backed-block-in-btree_split_sibling-error-path.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
30ce6e1cc5a0f781d60227e9096c86e188d2c2bdMon Sep 17 00:00:00 2001
From: Mike Snitzer <[email protected]>
Date: Mon, 23 Nov 2015 16:24:45 -0500
Subject: dm btree: fix leak of bufio-backed block in btree_split_sibling error path
From: Mike Snitzer <[email protected]>
commit 30ce6e1cc5a0f781d60227e9096c86e188d2c2bd upstream.
The block allocated at the start of btree_split_sibling() is never released if later insert_at() fails.
Fix this by releasing the previously allocated bufio block using unlock_block().
--- drivers/md/persistent-data/dm-btree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/md/persistent-data/dm-btree.c +3 -1
@@ -455,8 +455,10 @@ static int btree_split_sibling(struct sh r =insert_at (sizeof (__le64), pn, parent_index +1 ,le64_to_cpu (rn->keys[0 ]), &location); -if (r) +if (r) { +unlock_block (s->info, right);return r; + }if (key <le64_to_cpu (rn->keys[0 ])) {unlock_block (s->info, right);
Patches currently in stable-queue which might be from [email protected] are
queue-3.10/dm-btree-fix-leak-of-bufio-backed-block-in-btree_split_sibling-error-path.patch