Patch "crypto: algif_hash - Only export and import on sockets with data" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
crypto: algif_hash - Only export and import on sockets with data
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-algif_hash-only-export-and-import-on-sockets-with-data.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
4afa5f9617927453ac04b24b584f6c718dfb4f45Mon Sep 17 00:00:00 2001
From: Herbert Xu <[email protected]>
Date: Sun, 1 Nov 2015 17:11:19 +0800
Subject: crypto: algif_hash - Only export and import on sockets with data
From: Herbert Xu <[email protected]>
commit 4afa5f9617927453ac04b24b584f6c718dfb4f45 upstream.
The hash_accept call fails to work on sockets that have not received any data. For some algorithm implementations it may cause crashes.
This patch fixes this by ensuring that we only export and import on sockets that have received data.
--- crypto/algif_hash.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
crypto/algif_hash.c +10 -2
@@ -192,9 +192,14 @@ static int hash_accept(struct socket *sostruct sock *sk2;struct alg_sock *ask2;struct hash_ctx *ctx2; +bool more;int err; - err =crypto_ahash_export (req, state); +lock_sock (sk); + more = ctx->more; + err = more ?crypto_ahash_export (req, state) :0 ; +release_sock (sk); +if (err)return err;
@@ -205,7 +210,10 @@ static int hash_accept(struct socket *so sk2 = newsock->sk; ask2 =alg_sk (sk2); ctx2 = ask2->private; - ctx2->more =1 ; + ctx2->more = more; + +if (!more) +return err; err =crypto_ahash_import (&ctx2->req, state);if (err) {
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/crypto-algif_hash-only-export-and-import-on-sockets-with-data.patch