Skip to contentSkip to conversation

meta/conf/layer.conf: adapt to more flexible initramfs-framework RDEPENDS

PATCH In review Patrick Ohly 1 participant 3 messages Feb 8, 2016 – Feb 9, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta/conf/layer.conf: adapt to more flexible initramfs-framework RDEPENDS

initramfs-framework now RDEPENDS on ${VIRTUAL-RUNTIME_base-utils}, which can be busybox or some alternative like toybox. Making the SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS exception flexible, too, ensures that distros using toybox still pass the selftests.

---
 meta/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/layer.conf +1 -1
index 7100ed7..baa4fd4 100644
@@ -46,7 +46,7 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   ppp-dialin->ppp \
   resolvconf->bash \
   docbook-xsl-stylesheets->perl \
-  initramfs-framework->busybox \
+  initramfs-framework->${VIRTUAL-RUNTIME_base-utils} \
   initramfs-framework->systemd \
   initramfs-framework->udev \
   liberation-fonts->fontconfig \
Signature · 1 line
2.1.4
#1 lore raw
Quoted 15 lines · Patrick Ohly

initramfs-framework now RDEPENDS on ${VIRTUAL-RUNTIME_base-utils}, which can be busybox or some alternative like toybox. Making the SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS exception flexible, too, ensures that distros using toybox still pass the selftests.

---
 meta/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/layer.conf +0 -0
index 7100ed7..baa4fd4 100644

meta/conf/layer.conf SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ · line 52

Quoted 8 lines
meta/conf/layer.conf +1 -1
@@ -46,7 +46,7 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   ppp-dialin->ppp \
   resolvconf->bash \
   docbook-xsl-stylesheets->perl \
-  initramfs-framework->busybox \
+  initramfs-framework->${VIRTUAL-RUNTIME_base-utils} \
   initramfs-framework->systemd \
   initramfs-framework->udev \
   liberation-fonts->fontconfig \

Was VIRTUAL-RUNTIME_base-utils meant to be a single word?

I just noticed that toybox does not provide a /bin/sh out-of-the-box, and even when enabled the resulting sh is not complete enough to execute initramfs-framework scripts.

That means that VIRTUAL-RUNTIME_base-utils = "toybox" leads to an unusable initramfs when replacing "busybox" with ${VIRTUAL-RUNTIME_base-utils} in initramfs-framwork.

This could be fixed by setting
VIRTUAL-RUNTIME_base-utils = "toybox dash"
but then the patch above needs to be fixed.

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
#2 lore raw
Quoted 11 lines · Patrick Ohly
Quoted 10 lines · Patrick Ohly

initramfs-framework now RDEPENDS on ${VIRTUAL-RUNTIME_base-utils}, which can be busybox or some alternative like toybox. Making the SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS exception flexible, too, ensures that distros using toybox still pass the selftests.

---
 meta/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

meta/conf/layer.conf SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ · line 52

Quoted 13 lines
meta/conf/layer.conf +1 -1
index 7100ed7..baa4fd4 100644
@@ -46,7 +46,7 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   ppp-dialin->ppp \
   resolvconf->bash \
   docbook-xsl-stylesheets->perl \
-  initramfs-framework->busybox \
+  initramfs-framework->${VIRTUAL-RUNTIME_base-utils} \
   initramfs-framework->systemd \
   initramfs-framework->udev \
   liberation-fonts->fontconfig \

Was VIRTUAL-RUNTIME_base-utils meant to be a single word?

Apparently it was, for the sake of consistency with other VIRTUAL-RUNTIME variables.

Quoted 7 lines

I just noticed that toybox does not provide a /bin/sh out-of-the-box, and even when enabled the resulting sh is not complete enough to execute initramfs-framework scripts.

That means that VIRTUAL-RUNTIME_base-utils = "toybox" leads to an unusable initramfs when replacing "busybox" with ${VIRTUAL-RUNTIME_base-utils} in initramfs-framwork.

A better fix is probably to make toybox a full replacement (eventually) or make it RDEPEND on the missing pieces (current solution, for those who want it as busybox replacement).

Quoted 3 lines

This could be fixed by setting
VIRTUAL-RUNTIME_base-utils = "toybox dash"
but then the patch above needs to be fixed.

No, let's keep the patch as it is.

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.