Skip to contentSkip to conversation

liburcu: Support for NIOS2 architecture

PATCH Mathieu Desnoyers 2 participants 4 messages Feb 9, 2016 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 57 lines · ----- On Feb 9, 2016, at 11:55 AM, Marek Vasut [email protected] wrote:

Add support for the Altera NIOS2 CPU archirecture. The atomic operations are handled by the GCC. The memory barriers on this systems are entirely trivial too, since the CPU does not support SMP at all.

---

LICENSE              |  1 +
README.md            |  1 +
configure.ac         |  1 +
urcu/arch/nios2.h    | 40 ++++++++++++++++++++++++++++++++++++++++
urcu/uatomic/nios2.h | 32 ++++++++++++++++++++++++++++++++
5 files changed, 75 insertions(+)

create mode 100644 urcu/arch/nios2.h
create mode 100644 urcu/uatomic/nios2.h

LICENSE +0 -0
index 3147094..a06fdcc 100644
@@ -45,6 +45,7 @@ compiler.h

arch/s390.h
uatomic/alpha.h
uatomic/mips.h
+uatomic/nios2.h
uatomic/s390.h
system.h

README.md +1 -0
index f6b290f..6fe9c1e 100644
@@ -43,6 +43,7 @@ Currently, the following architectures are supported:
  - S390, S390x
  - ARM 32/64
  - MIPS
+  - NIOS2
  - Alpha
  - ia64
  - Sparcv9 32/64
configure.ac +1 -0
index 39a7777..71a7d71 100644
@@ -124,6 +124,7 @@ AS_CASE([$host_cpu],
 	[arm*], [ARCHTYPE="arm"],
 	[aarch64], [ARCHTYPE="aarch64"],
 	[mips*], [ARCHTYPE="mips"],
+	[nios2*], [ARCHTYPE="nios2"],
 	[tile*], [ARCHTYPE="tile"],
 	[hppa*], [ARCHTYPE="hppa"],
 	[ARCHTYPE="unknown"]
urcu/arch/nios2.h new file +0 -0
new file mode 100644
index 0000000..030d1bc

urcu/arch/nios2.h line 5

Quoted 5 lines
urcu/arch/nios2.h new file +5 -0
@@ -0,0 +1,40 @@
+#ifndef _URCU_ARCH_NIOS2_H
+#define _URCU_ARCH_NIOS2_H
+
+/*
+ * arch_mips.h: trivial definitions for the NIOS2 architecture.

mips -> nops2

Quoted 17 lines
urcu/arch/nios2.h new file +17 -0
+ *
+ * Copyright (c) 2016 Marek Vasut <[email protected]>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */

urcu/arch/nios2.h line 32

Quoted 10 lines
urcu/arch/nios2.h new file +10 -0
+
+#include <urcu/compiler.h>
+#include <urcu/config.h>
+#include <urcu/syscall-compat.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#define cmm_mb()	__asm__ __volatile__ ("":::"memory")

please change for:

#define cmm_mb() cmm_barrier()

to re-use the cmm_barrier macro from urcu/compiler.h

The rest looks good, can you prepare an updated patch ?

Thanks!

Mathieu

Quoted 54 lines
urcu/arch/nios2.h new file +8 -0
+
+#ifdef __cplusplus
+}
+#endif
+
+#include <urcu/arch/generic.h>
+
+#endif /* _URCU_ARCH_NIOS2_H */
urcu/uatomic/nios2.h new file +32 -1
new file mode 100644
index 0000000..5b3c303
@@ -0,0 +1,32 @@
+#ifndef _URCU_UATOMIC_ARCH_NIOS2_H
+#define _URCU_UATOMIC_ARCH_NIOS2_H
+
+/*
+ * Atomic exchange operations for the NIOS2 architecture. Let GCC do it.
+ *
+ * Copyright (c) 2016 Marek Vasut <[email protected]>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+#include <urcu/compiler.h>
+#include <urcu/system.h>
+#include <urcu/uatomic/generic.h>
+
+#endif /* _URCU_UATOMIC_ARCH_NIOS2_H */
--

2.7.0

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 60 lines · Mathieu Desnoyers
Quoted 59 lines · ----- On Feb 9, 2016, at 11:55 AM, Marek Vasut [email protected] wrote:

Add support for the Altera NIOS2 CPU archirecture. The atomic operations are handled by the GCC. The memory barriers on this systems are entirely trivial too, since the CPU does not support SMP at all.

---

LICENSE              |  1 +
README.md            |  1 +
configure.ac         |  1 +
urcu/arch/nios2.h    | 40 ++++++++++++++++++++++++++++++++++++++++
urcu/uatomic/nios2.h | 32 ++++++++++++++++++++++++++++++++
5 files changed, 75 insertions(+)

create mode 100644 urcu/arch/nios2.h
create mode 100644 urcu/uatomic/nios2.h

LICENSE +0 -0
index 3147094..a06fdcc 100644
@@ -45,6 +45,7 @@ compiler.h

arch/s390.h
uatomic/alpha.h
uatomic/mips.h
+uatomic/nios2.h
uatomic/s390.h
system.h

README.md +1 -0
index f6b290f..6fe9c1e 100644
@@ -43,6 +43,7 @@ Currently, the following architectures are supported:
  - S390, S390x
  - ARM 32/64
  - MIPS
 
+  - NIOS2
 
  - Alpha

- ia64
- Sparcv9 32/64

configure.ac +1 -0
index 39a7777..71a7d71 100644
@@ -124,6 +124,7 @@ AS_CASE([$host_cpu],
 
 	[arm*], [ARCHTYPE="arm"],
 	[aarch64], [ARCHTYPE="aarch64"],
 	[mips*], [ARCHTYPE="mips"],
 
+	[nios2*], [ARCHTYPE="nios2"],
 
	[tile*], [ARCHTYPE="tile"],
	[hppa*], [ARCHTYPE="hppa"],
	[ARCHTYPE="unknown"]
Quoted 13 lines

urcu/arch/nios2.h line 5

Quoted 11 lines
urcu/arch/nios2.h new file +5 -0
new file mode 100644
index 0000000..030d1bc
@@ -0,0 +1,40 @@
+#ifndef _URCU_ARCH_NIOS2_H
+#define _URCU_ARCH_NIOS2_H
+
+/*
+ * arch_mips.h: trivial definitions for the NIOS2 architecture.

mips -> nops2

Oops :-) Now it's clear where I started. Fixed, nice catch.

Quoted 30 lines
Quoted 17 lines
urcu/arch/nios2.h new file +16 -0
+ *
+ * Copyright (c) 2016 Marek Vasut <[email protected]>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

02110-1301 USA + */

urcu/arch/nios2.h

Quoted 10 lines
urcu/arch/nios2.h new file +10 -0
+
+#include <urcu/compiler.h>
+#include <urcu/config.h>
+#include <urcu/syscall-compat.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#define cmm_mb()	__asm__ __volatile__ ("":::"memory")

please change for:

Quoted 3 lines

#define cmm_mb() cmm_barrier()

to re-use the cmm_barrier macro from urcu/compiler.h

Nice!

Quoted 1 line

The rest looks good, can you prepare an updated patch ?

Done, thanks!

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 75 lines · ----- On Feb 9, 2016, at 1:31 PM, Marek Vasut [email protected] wrote:
Quoted 60 lines · Mathieu Desnoyers
Quoted 59 lines · ----- On Feb 9, 2016, at 11:55 AM, Marek Vasut [email protected] wrote:

Add support for the Altera NIOS2 CPU archirecture. The atomic operations are handled by the GCC. The memory barriers on this systems are entirely trivial too, since the CPU does not support SMP at all.

---

LICENSE              |  1 +
README.md            |  1 +
configure.ac         |  1 +
urcu/arch/nios2.h    | 40 ++++++++++++++++++++++++++++++++++++++++
urcu/uatomic/nios2.h | 32 ++++++++++++++++++++++++++++++++
5 files changed, 75 insertions(+)

create mode 100644 urcu/arch/nios2.h
create mode 100644 urcu/uatomic/nios2.h

LICENSE +0 -0
index 3147094..a06fdcc 100644
@@ -45,6 +45,7 @@ compiler.h

arch/s390.h
uatomic/alpha.h
uatomic/mips.h
+uatomic/nios2.h
uatomic/s390.h
system.h

README.md +1 -0
index f6b290f..6fe9c1e 100644
@@ -43,6 +43,7 @@ Currently, the following architectures are supported:
  - S390, S390x
  - ARM 32/64
  - MIPS
 
+  - NIOS2
 
  - Alpha

- ia64
- Sparcv9 32/64

configure.ac +1 -0
index 39a7777..71a7d71 100644
@@ -124,6 +124,7 @@ AS_CASE([$host_cpu],
 
 	[arm*], [ARCHTYPE="arm"],
 	[aarch64], [ARCHTYPE="aarch64"],
 	[mips*], [ARCHTYPE="mips"],
 
+	[nios2*], [ARCHTYPE="nios2"],
 
	[tile*], [ARCHTYPE="tile"],
	[hppa*], [ARCHTYPE="hppa"],
	[ARCHTYPE="unknown"]
Quoted 13 lines

urcu/arch/nios2.h line 5

Quoted 11 lines
urcu/arch/nios2.h new file +5 -0
new file mode 100644
index 0000000..030d1bc
@@ -0,0 +1,40 @@
+#ifndef _URCU_ARCH_NIOS2_H
+#define _URCU_ARCH_NIOS2_H
+
+/*
+ * arch_mips.h: trivial definitions for the NIOS2 architecture.

mips -> nops2

Quoted 1 line

Oops :-) Now it's clear where I started. Fixed, nice catch.

of course, I meant "nios2" here (not nops2). It's a nice typo though ;)

Thanks,

Mathieu

Quoted 40 lines
Quoted 31 lines
Quoted 18 lines
urcu/arch/nios2.h new file +16 -0
+ *
+ * Copyright (c) 2016 Marek Vasut <[email protected]>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

02110-1301 USA + */

urcu/arch/nios2.h

Quoted 10 lines
urcu/arch/nios2.h new file +10 -0
+
+#include <urcu/compiler.h>
+#include <urcu/config.h>
+#include <urcu/syscall-compat.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#define cmm_mb()	__asm__ __volatile__ ("":::"memory")

please change for:

Quoted 3 lines

#define cmm_mb() cmm_barrier()

to re-use the cmm_barrier macro from urcu/compiler.h

Nice!

Quoted 1 line

The rest looks good, can you prepare an updated patch ?

Done, thanks!

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 77 lines · Mathieu Desnoyers
Quoted 76 lines · ----- On Feb 9, 2016, at 1:31 PM, Marek Vasut [email protected] wrote:
Quoted 74 lines · Mathieu Desnoyers
Quoted 66 lines · ----- On Feb 9, 2016, at 11:55 AM, Marek Vasut [email protected] wrote:

Add support for the Altera NIOS2 CPU archirecture. The atomic operations are handled by the GCC. The memory barriers on this systems are entirely trivial too, since the CPU does not support SMP at all.

---

LICENSE              |  1 +
README.md            |  1 +
configure.ac         |  1 +
urcu/arch/nios2.h    | 40 ++++++++++++++++++++++++++++++++++++++++
urcu/uatomic/nios2.h | 32 ++++++++++++++++++++++++++++++++
5 files changed, 75 insertions(+)

create mode 100644 urcu/arch/nios2.h
create mode 100644 urcu/uatomic/nios2.h

LICENSE +0 -0
index 3147094..a06fdcc 100644
@@ -45,6 +45,7 @@ compiler.h

arch/s390.h
uatomic/alpha.h
uatomic/mips.h
+uatomic/nios2.h
uatomic/s390.h
system.h

README.md +1 -0
index f6b290f..6fe9c1e 100644
@@ -43,6 +43,7 @@ Currently, the following architectures are supported:
  - S390, S390x
  - ARM 32/64
  - MIPS
 
+  - NIOS2
 
  - Alpha

- ia64
- Sparcv9 32/64

configure.ac +1 -0
index 39a7777..71a7d71 100644
@@ -124,6 +124,7 @@ AS_CASE([$host_cpu],
 
 	[arm*], [ARCHTYPE="arm"],
 	[aarch64], [ARCHTYPE="aarch64"],
 	[mips*], [ARCHTYPE="mips"],
 
+	[nios2*], [ARCHTYPE="nios2"],
 
	[tile*], [ARCHTYPE="tile"],
	[hppa*], [ARCHTYPE="hppa"],
	[ARCHTYPE="unknown"]
urcu/arch/nios2.h new file +0 -0
new file mode 100644
index 0000000..030d1bc

urcu/arch/nios2.h line 5

Quoted 5 lines
urcu/arch/nios2.h new file +5 -0
@@ -0,0 +1,40 @@
+#ifndef _URCU_ARCH_NIOS2_H
+#define _URCU_ARCH_NIOS2_H
+
+/*
+ * arch_mips.h: trivial definitions for the NIOS2 architecture.

mips -> nops2

Quoted 3 lines
Quoted 1 line

Oops :-) Now it's clear where I started. Fixed, nice catch.

of course, I meant "nios2" here (not nops2). It's a nice typo though ;)

The nios2 doens't need any nops, it's slow as it is ;-)