Patch "ocfs2: fix SGID not inherited issue" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ocfs2: fix SGID not inherited issue
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ocfs2-fix-sgid-not-inherited-issue.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
854ee2e944b4daf795e32562a7d2f9e90ab5a6a8Mon Sep 17 00:00:00 2001
From: Junxiao Bi <[email protected]>
Date: Fri, 11 Dec 2015 13:41:03 -0800
Subject: ocfs2: fix SGID not inherited issue
From: Junxiao Bi <[email protected]>
commit 854ee2e944b4daf795e32562a7d2f9e90ab5a6a8 upstream.
Commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, SGID of sub dir was not inherited from its parents dir. It is because SGID is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten by "mode" which don't have SGID set later.
--- fs/ocfs2/namei.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fs/ocfs2/namei.c +1 -3
@@ -340,13 +340,11 @@ static int ocfs2_mknod(struct inode *dir goto leave; } - status =posix_acl_create (dir, &mode, &default_acl, &acl); + status =posix_acl_create (dir, &inode->i_mode, &default_acl, &acl);if (status) {mlog_errno (status); goto leave; } -/* update inode->i_mode after mask with "umask". */ - inode->i_mode = mode; handle = ocfs2_start_trans(osb, ocfs2_mknod_credits(osb->sb, S_ISDIR(mode),
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/ocfs2-dlm-ignore-cleaning-the-migration-mle-that-is-inuse.patch queue-3.14/ocfs2-fix-sgid-not-inherited-issue.patch queue-3.14/ocfs2-dlm-clear-refmap-bit-of-recovery-lock-while-doing-local-recovery-cleanup.patch