Skip to contentSkip to conversation

drivers/staging/android: don't use modular references in sync_debug.c

PATCH New Paul Gortmaker 1 participant 1 message Feb 13, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/staging/android: don't use modular references in sync_debug.c

In commit 8a0044846115e74552b671a7073cffeec14b9316 ("staging/android:
create a 'sync' dir for debugfs information"), modular references were introduced to this file. However if we look, we find:

drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o

drivers/staging/android/Kconfig:config SYNC
drivers/staging/android/Kconfig: bool "Synchronization framework"

This file isn't currently buildable as a module, and hence the code for module_exit is just dead code. Remove it and the module.h include.

Cc Gustavo Padovan <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/android/sync_debug.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/staging/android/sync_debug.c +0 -8
index fd13f1e885e5..5a7ec58fbc09 100644
@@ -15,7 +15,6 @@
  */
 
 #include <linux/debugfs.h>
-#include <linux/module.h>
 #include <linux/export.h>
 #include <linux/file.h>
 #include <linux/fs.h>
@@ -335,13 +334,6 @@ static __init int sync_debugfs_init(void)
 }
 late_initcall(sync_debugfs_init);
 
-static __exit void sync_debugfs_exit(void)
-{
-	if (dbgfs)
-		debugfs_remove_recursive(dbgfs);
-}
-module_exit(sync_debugfs_exit);
-
 #define DUMP_CHUNK 256
 static char sync_dump_buf[64 * 1024];
 void sync_dump(void)
Signature · 1 line
2.6.1