Skip to contentSkip to conversation

Patch "USB: serial: visor: fix crash on detecting device without write_urbs" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Feb 14, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: visor: fix crash on detecting device without write_urbs

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-visor-fix-crash-on-detecting-device-without-write_urbs.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cb3232138e37129e88240a98a1d2aba2187ff57c Mon Sep 17 00:00:00 2001

From: Vladis Dronov <[email protected]>
Date: Tue, 12 Jan 2016 15:10:50 +0100
Subject: USB: serial: visor: fix crash on detecting device without write_urbs

From: Vladis Dronov <[email protected]>

commit cb3232138e37129e88240a98a1d2aba2187ff57c upstream.

The visor driver crashes in clie_5_attach() when a specially crafted USB device without bulk-out endpoint is detected. This fix adds a check that the device has proper configuration expected by the driver.

Fixes cfb8da8f69b8 ("USB: visor: fix initialisation of UX50/TH55 devices")
---
 drivers/usb/serial/visor.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/serial/visor.c +4 -2
@@ -604,8 +604,10 @@ static int clie_5_attach(struct usb_seri
 	 */
 
 	/* some sanity check */
-	if (serial->num_ports < 2)
-		return -1;
+	if (serial->num_bulk_out < 2) {
+		dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
+		return -ENODEV;
+	}
 
 	/* port 0 now uses the modified endpoint Address */
 	port = serial->port[0];

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/usb-serial-visor-fix-crash-on-detecting-device-without-write_urbs.patch