Skip to contentSkip to conversation

gpio: tpic2810: Make tpic2810_direction_output set proper output level

PATCH In review Axel Lin 2 participants 4 messages Feb 15, 2016 – Feb 16, 2016 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 gpio: tpic2810: Make tpic2810_direction_output set proper output level

The .direction_output callback should set proper output level.

---
 drivers/gpio/gpio-tpic2810.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpio/gpio-tpic2810.c +3 -0
index 032d058..9f020aa 100644
@@ -33,6 +33,8 @@ struct tpic2810 {
 	struct mutex lock;
 };
 
+static void tpic2810_set(struct gpio_chip *chip, unsigned offset, int value);
+
 static int tpic2810_get_direction(struct gpio_chip *chip,
 				  unsigned offset)
 {
@@ -51,6 +53,7 @@ static int tpic2810_direction_output(struct gpio_chip *chip,
 				     unsigned offset, int value)
 {
 	/* This device always output */
+	tpic2810_set(chip, offset, value);
 	return 0;
 }
 
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 2/2 gpio: tps65218: Make tps65218_gpio_output set proper output level

The .direction_output callback should set proper output level.

---
 drivers/gpio/gpio-tps65218.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-tps65218.c +1 -0
index 7b02f7b..a308a0b 100644
@@ -59,6 +59,7 @@ static int tps65218_gpio_output(struct gpio_chip *gc, unsigned offset,
 				int value)
 {
 	/* Only drives GPOs */
+	tps65218_gpio_set(gc, offset, value);
 	return 0;
 }
 
Signature · 1 line
2.1.4
#2 lore raw

Re: [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output set proper output level

Quoted 3 lines · Axel Lin

The .direction_output callback should set proper output level.

Obviously correct, patch applied.

Yours,
Linus Walleij