Skip to contentSkip to conversation

dmsetup: treat no devices found as error

PATCH New Hannes Reinecke 2 participants 2 messages Feb 17, 2016

lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 dmsetup: treat no devices found as error

When calling 'dmsetup ls' and no devices are found the program will print out 'No devices found' and exit normally.
This makes it really hard for the calling application to determine if the output 'No devices found' is a valid device or not. This patch moves the 'No devices found' string to stderr and sets the return code to non-0 to allow calling applications to better differentiate here.

Signed-off-by Hannes Reinecke <[email protected]>
---
 tools/dmsetup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/dmsetup.c +2 -1
index 4db6004..3629931 100644
@@ -1835,7 +1835,8 @@ static int _process_all(const struct command *cmd, const char *subcommand, int a
 
 	if (!names->dev) {
 		if (!silent)
-			printf("No devices found\n");
+			fprintf(stderr, "No devices found\n");
+		r = 0;
 		goto out;
 	}
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 dmsetup: treat no devices found as error

Dne 17.2.2016 v 08:51 Hannes Reinecke napsal(a):

Quoted 18 lines

When calling 'dmsetup ls' and no devices are found the program will print out 'No devices found' and exit normally.
This makes it really hard for the calling application to determine if the output 'No devices found' is a valid device or not. This patch moves the 'No devices found' string to stderr and sets the return code to non-0 to allow calling applications to better differentiate here.

Signed-off-by Hannes Reinecke <[email protected]>
---
  tools/dmsetup.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tools/dmsetup.c +0 -0
index 4db6004..3629931 100644

tools/dmsetup.c static int _process_all(const struct command *cmd, const char *subcommand, int a · line 1842

Quoted 9 lines
tools/dmsetup.c +2 -1
@@ -1835,7 +1835,8 @@ static int _process_all(const struct command *cmd, const char *subcommand, int a
 
  	if (!names->dev) {
  		if (!silent)
-			printf("No devices found\n");
+			fprintf(stderr, "No devices found\n");
+		r = 0;
  		goto out;
  	}

Hi

NACKing this patch.

dmsetup cannot change behavior this way - it'd cause major regression for existing script using dmsetup (rule #1 - no regressions).

'No devices found' when you list empty table is correct & expected state.

So return code is 'success' in this case
(and as success output goes to stdout).

I'm actually not even sure why would you want to base ANY script on error code
as empty dm table is not an error (btw with this logic 'dmsetup table' for
empty table would also need to return error and so on...)

You may get mapping pairs major:minor with 'dmsetup ls -o devno' :

"vg-lvol0 (253:0)"
...

or with 'dmsetup ls -o blkdevname' pairs like this:

"vg-lvol0 (dm-0)"
...

and when no device exists:
"No devices found"

and all you need to do is just check for string on output line (stdout). (i.e. line does not have '(', ':', ')' --> so it's empty table --> no device...)

Technically I don't see much difference in checking string or error code (which is just not an error).

On the other hand - when 'dmsetup' has a real error - you should take correct steps to work around some real error (e.g. out-of-mem system). But usually 'error' code behavior is 'exception' state - and as exception it's typically more 'expensive' in code handling...

Regards

Zdenek