Skip to contentSkip to conversation

selftests: breakpoint: add step_after_suspend_test

PATCH In review Greg Hackmann 2 participants 2 messages Feb 22, 2016 – Feb 23, 2016 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: breakpoint: add step_after_suspend_test

Commit e56d82a11617 ("arm64: cpu hotplug: ensure we mask out CPU_TASKS_FROZEN in notifiers") fixed a long-standing ARM64 bug that broke single-stepping after a suspend/resume cycle. Add a kernel selftest to make sure this doesn't regress or affect other platforms.

---
 tools/testing/selftests/breakpoints/Makefile       |   4 +-
 .../breakpoints/step_after_suspend_test.c          | 219 +++++++++++++++++++++
 2 files changed, 222 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/breakpoints/step_after_suspend_test.c
tools/testing/selftests/breakpoints/Makefile +3 -1
index c0d9570..74e533f 100644
@@ -6,9 +6,11 @@ ifeq ($(ARCH),x86)
 TEST_PROGS := breakpoint_test
 endif
 
+TEST_PROGS += step_after_suspend_test
+
 all: $(TEST_PROGS)
 
 include ../lib.mk
 
 clean:
-	rm -fr breakpoint_test
+	rm -fr breakpoint_test step_after_suspend_test
tools/testing/selftests/breakpoints/step_after_suspend_test.c new file +219 -0

219 lines not on this page · raw message

Signature · 1 line
2.7.0.rc3.207.g0ac5344
#1 lore raw
Quoted 5 lines · Greg Hackmann

Commit e56d82a11617 ("arm64: cpu hotplug: ensure we mask out CPU_TASKS_FROZEN in notifiers") fixed a long-standing ARM64 bug that broke single-stepping after a suspend/resume cycle. Add a kernel selftest to make sure this doesn't regress or affect other platforms.

Quoted 7 lines
---
 tools/testing/selftests/breakpoints/Makefile       |   4 +-
 .../breakpoints/step_after_suspend_test.c          | 219 +++++++++++++++++++++
 2 files changed, 222 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/breakpoints/step_after_suspend_test.c

Thanks for the patch. There is a whitespace error which I fixed. No need to resend this patch. Please make sure to run checkpatch.pl on your future patches.

Applied to linux-kselftest next for 4.6-rc1

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978