amdgpu: fix NULL pointer dereference at tonga_check_states_equal
Subsystems (2)
PATCH 1/1 amdgpu: fix NULL pointer dereference at tonga_check_states_equal
The event_data passed from pem_fini was not cleared upon initialization. This caused NULL checks to pass and cast_const_phw_tonga_power_state to attempt to dereference an invalid pointer. Clear the event_data in pem_init and pem_fini before calling pem_handle_event.
--- drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c +2 -2
@@ -31,7 +31,7 @@static int pem_init (struct pp_eventmgr *eventmgr) {int result =0 ; -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };/* Initialize PowerPlay feature info */ pem_init_feature_info (eventmgr);
@@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)static void pem_fini (struct pp_eventmgr *eventmgr) { -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };pem_uninit_featureInfo (eventmgr);pem_unregister_interrupts (eventmgr);
Signature · 1 line
2.7.1
Best Regards
Rex Zhu
-----Original Message-----
From: Bradley Pankow [mailto:[email protected]]
Sent: Tuesday, February 23, 2016 9:12 AM
To: Deucher, Alexander; Zhu, Rex; Zhou, Jammy
Cc: [email protected]; [email protected]; Bradley Pankow
Subject: [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
The event_data passed from pem_fini was not cleared upon initialization.
This caused NULL checks to pass and cast_const_phw_tonga_power_state to attempt to dereference an invalid pointer. Clear the event_data in pem_init and pem_fini before calling pem_handle_event.
--- drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c +2 -3
@@ -31,7 +31,7 @@static int pem_init (struct pp_eventmgr *eventmgr) {int result =0 ; -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };/* Initialize PowerPlay feature info */ pem_init_feature_info (eventmgr);
@@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)static void pem_fini (struct pp_eventmgr *eventmgr) { -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };pem_uninit_featureInfo (eventmgr);pem_unregister_interrupts (eventmgr); --
2.7.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedApplied. thanks!
Alex
Quoted 44 lines · Rex
Reviewed-by Rex Zhu <[email protected]>Best Regards
Rex Zhu-----Original Message-----
From: Bradley Pankow [mailto:[email protected]]
Sent: Tuesday, February 23, 2016 9:12 AM
To: Deucher, Alexander; Zhu, Rex; Zhou, Jammy
Cc: [email protected]; [email protected]; Bradley Pankow
Subject: [PATCH] amdgpu: fix NULL pointer dereference attonga_check_states_equalThe
event_datapassed frompem_finiwas not cleared upon initialization.
This caused NULL checks to pass andcast_const_phw_tonga_power_stateto attempt to dereference an invalid pointer. Clear theevent_datainpem_initandpem_finibefore callingpem_handle_event.Signed-off-by Bradley Pankow <[email protected]>--- drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c +2
-3@@ -31,7 +31,7 @@static int pem_init (struct pp_eventmgr *eventmgr) {int result =0 ; -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };/* Initialize PowerPlay feature info */ pem_init_feature_info (eventmgr);@@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)static void pem_fini (struct pp_eventmgr *eventmgr) { -struct pem_event_data event_data; +struct pem_event_data event_data = { {0 } };pem_uninit_featureInfo (eventmgr);pem_unregister_interrupts (eventmgr); --2.7.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel