Skip to contentSkip to conversation

Patch "intel_scu_ipcutil: underflow in scu_reg_access()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 24, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

intel_scu_ipcutil: underflow in scu_reg_access()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
intel_scu_ipcutil-underflow-in-scu_reg_access.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b1d353ad3d5835b16724653b33c05124e1b5acf1 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 26 Jan 2016 12:24:25 +0300
Subject: intel_scu_ipcutil: underflow in scu_reg_access()

From: Dan Carpenter <[email protected]>

commit b1d353ad3d5835b16724653b33c05124e1b5acf1 upstream.

"count" is controlled by the user and it can be negative. Let's prevent that by making it unsigned. You have to have CAP_SYS_RAWIO to call this function so the bug is not as serious as it could be.

Fixes 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
---
 drivers/platform/x86/intel_scu_ipcutil.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_scu_ipcutil.c +1 -1
@@ -49,7 +49,7 @@ struct scu_ipc_data {
 
 static int scu_reg_access(u32 cmd, struct scu_ipc_data  *data)
 {
-	int count = data->count;
+	unsigned int count = data->count;
 
 	if (count == 0 || count == 3 || count > 4)
 		return -EINVAL;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/intel_scu_ipcutil-underflow-in-scu_reg_access.patch queue-4.4/iio-inkern-fix-a-null-dereference-on-error.patch