Skip to contentSkip to conversation

Patch "ovl: allow zero size xattr" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 24, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: allow zero size xattr

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-allow-zero-size-xattr.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 97daf8b97ad6f913a34c82515be64dc9ac08d63e Mon Sep 17 00:00:00 2001

From: Miklos Szeredi <[email protected]>
Date: Tue, 10 Nov 2015 17:08:41 +0100
Subject: ovl: allow zero size xattr

From: Miklos Szeredi <[email protected]>

commit 97daf8b97ad6f913a34c82515be64dc9ac08d63e upstream.

When ovl_copy_xattr() encountered a zero size xattr no more xattrs were copied and the function returned success. This is clearly not the desired behavior.

---
 fs/overlayfs/copy_up.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/overlayfs/copy_up.c +1 -1
@@ -54,7 +54,7 @@ int ovl_copy_xattr(struct dentry *old, s
 
 	for (name = buf; name < (buf + list_size); name += strlen(name) + 1) {
 		size = vfs_getxattr(old, name, value, XATTR_SIZE_MAX);
-		if (size <= 0) {
+		if (size < 0) {
 			error = size;
 			goto out_free_value;
 		}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ovl-allow-zero-size-xattr.patch queue-4.4/ovl-root-copy-attr.patch queue-4.4/ovl-check-dentry-positiveness-in-ovl_cleanup_whiteouts.patch queue-4.4/ovl-setattr-check-permissions-before-copy-up.patch queue-4.4/ovl-use-a-minimal-buffer-in-ovl_copy_xattr.patch