Skip to contentSkip to conversation

watchdog: orion: Depend on 32-bit ARM

PATCH In review Thierry Reding 3 participants 3 messages Feb 24, 2016 – Mar 4, 2016 Watchdog device drivers

lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 watchdog: orion: Depend on 32-bit ARM

From: Thierry Reding <[email protected]>

The driver uses the atomic_io_modify() function to update registers, but that function is only available on 32-bit ARM. Recent changes have added ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build on 64-bit ARM where this function isn't available and thereby causing allmodconfig builds to break.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 9289da313d98..cfec157488b1 100644
@@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
 config ORION_WATCHDOG
 	tristate "Orion watchdog"
 	depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
+	depends on ARM
 	select WATCHDOG_CORE
 	help
 	  Say Y here if to include support for the watchdog timer
Signature · 1 line
2.7.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The driver uses the atomic_io_modify() function to update registers, but that function is only available on 32-bit ARM. Recent changes have added ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build on 64-bit ARM where this function isn't available and thereby causing allmodconfig builds to break.

Signed-off-by Thierry Reding <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 17 lines
---
  drivers/watchdog/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 9289da313d98..cfec157488b1 100644
@@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
  config ORION_WATCHDOG
  	tristate "Orion watchdog"
  	depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
+	depends on ARM
  	select WATCHDOG_CORE
  	help
  	  Say Y here if to include support for the watchdog timer
#2 lore raw
In reply to Thierry Reding

Hi Thierry,

Quoted 28 lines

From: Thierry Reding <[email protected]>

The driver uses the atomic_io_modify() function to update registers, but that function is only available on 32-bit ARM. Recent changes have added ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build on 64-bit ARM where this function isn't available and thereby causing allmodconfig builds to break.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 9289da313d98..cfec157488b1 100644
@@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
 config ORION_WATCHDOG
 	tristate "Orion watchdog"
 	depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
+	depends on ARM
 	select WATCHDOG_CORE
 	help
 	  Say Y here if to include support for the watchdog timer
Signature · 1 line
2.7.1

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.