Skip to contentSkip to conversation

Patch "net_sched fix: reclassification needs to consider ether protocol changes" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 29, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net_sched fix: reclassification needs to consider ether protocol changes

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net_sched-fix-reclassification-needs-to-consider-ether-protocol-changes.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Feb 29 14:33:50 PST 2016

From: Jamal Hadi Salim <[email protected]>
Date: Thu, 18 Feb 2016 07:38:04 -0500
Subject: net_sched fix: reclassification needs to consider ether protocol changes

From: Jamal Hadi Salim <[email protected]>

[ Upstream commit 619fe32640b4b01f370574d50344ae0f62689816 ]

actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart the classification with the new proto header.

Example setup used to catch this:
sudo tc qdisc add dev $ETH ingress
sudo $TC filter add dev $ETH parent ffff: pref 1 protocol 802.1Q \
u32 match u32 0 0 flowid 1:1 \
action vlan pop reclassify

Fixes 3b3ae880266d ("net: sched: consolidate tc_classify{,_compat}")
---
 net/sched/sch_api.c |    1 +
 1 file changed, 1 insertion(+)
net/sched/sch_api.c +1 -0
@@ -1852,6 +1852,7 @@ reset:
 	}
 
 	tp = old_tp;
+	protocol = tc_skb_protocol(skb);
 	goto reclassify;
 #endif
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/net_sched-fix-reclassification-needs-to-consider-ether-protocol-changes.patch