Patch "sctp: translate network order to host order when users get a hmacid" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
sctp: translate network order to host order when users get a hmacid
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
sctp-translate-network-order-to-host-order-when-users-get-a-hmacid.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Feb 29 14:33:50 PST 2016
From: Xin Long <[email protected]>
Date: Wed, 3 Feb 2016 23:33:30 +0800
Subject: sctp: translate network order to host order when users get a hmacid
From: Xin Long <[email protected]>
[ Upstream commit 7a84bd46647ff181eb2659fdc99590e6f16e501d ]
Commit ed5a377d87dc ("sctp: translate host order to network order when setting a hmacid") corrected the hmacid byte-order when setting a hmacid. but the same issue also exists on getting a hmacid.
We fix it by changing hmacids to host order when users get them with getsockopt.
--- net/sctp/socket.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
net/sctp/socket.c +7 -2
@@ -5542,6 +5542,7 @@ static int sctp_getsockopt_hmac_ident(ststruct sctp_hmac_algo_param *hmacs;__u16 data_len =0 ;u32 num_idents; +int i;if (!ep->auth_enable)return -EACCES ;
@@ -5559,8 +5560,12 @@ static int sctp_getsockopt_hmac_ident(streturn -EFAULT ;if (put_user (num_idents, &p->shmac_num_idents))return -EFAULT ; -if (copy_to_user (p->shmac_idents, hmacs->hmac_ids, data_len)) -return -EFAULT ; +for (i =0 ; i < num_idents; i++) { +__u16 hmacid =ntohs (hmacs->hmac_ids[i]); + +if (copy_to_user (&p->shmac_idents[i], &hmacid,sizeof (__u16))) +return -EFAULT ; + }return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/sctp-translate-network-order-to-host-order-when-users-get-a-hmacid.patch queue-4.4/route-check-and-remove-route-cache-when-we-get-route.patch