Patch "efi: Do variable name validation tests in utf8" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
efi: Do variable name validation tests in utf8
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
efi-do-variable-name-validation-tests-in-utf8.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
3dcb1f55dfc7631695e69df4a0d589ce5274bd07Mon Sep 17 00:00:00 2001
From: Peter Jones <[email protected]>
Date: Mon, 8 Feb 2016 14:48:13 -0500
Subject: efi: Do variable name validation tests in utf8
From: Peter Jones <[email protected]>
commit 3dcb1f55dfc7631695e69df4a0d589ce5274bd07 upstream.
Actually translate from ucs2 to utf8 before doing the test, and then test against our other utf8 data, instead of fudging it.
--- drivers/firmware/efi/vars.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-)
drivers/firmware/efi/vars.c +21 -11
@@ -189,10 +189,19 @@ static const struct variable_validate va };bool -efivar_validate (efi_char16_t *var_name,u8 *data,unsigned long len) +efivar_validate (efi_char16_t *var_name,u8 *data,unsigned long data_size) {int i; -u16 *unicode_name = var_name; +unsigned long utf8_size; +u8 *utf8_name; + + utf8_size =ucs2_utf8size (var_name); + utf8_name =kmalloc (utf8_size +1 ,GFP_KERNEL ); +if (!utf8_name) +return false; + +ucs2_as_utf8 (utf8_name, var_name, utf8_size); + utf8_name[utf8_size] ='\0' ;for (i =0 ; variable_validate[i].validate !=NULL ; i++) {const char *name = variable_validate[i].name;
@@ -200,28 +209,29 @@ efivar_validate(efi_char16_t *var_name,for (match =0 ; ; match++) {char c = name[match]; -u16 u = unicode_name[match]; - -/* All special variables are plain ascii */ -if (u >127 ) -return true; +char u = utf8_name[match];/* Wildcard in the matching name means we've matched */ -if (c =='*' ) +if (c =='*' ) { +kfree (utf8_name);return variable_validate[i].validate (var_name, - match, data, len); + match, data, data_size); + }/* Case sensitive match */ if (c != u)break ;/* Reached the end of the string while matching */ -if (!c) +if (!c) { +kfree (utf8_name);return variable_validate[i].validate (var_name, - match, data, len); + match, data, data_size); + } } } +kfree (utf8_name);return true; }EXPORT_SYMBOL_GPL (efivar_validate);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/efi-do-variable-name-validation-tests-in-utf8.patch queue-4.4/efi-make-our-variable-validation-list-include-the-guid.patch queue-4.4/efi-use-ucs2_as_utf8-in-efivarfs-instead-of-open-coding-a-bad-version.patch queue-4.4/efi-add-pstore-variables-to-the-deletion-whitelist.patch queue-4.4/efi-make-efivarfs-entries-immutable-by-default.patch queue-4.4/lib-ucs2_string-correct-ucs2-utf8-conversion.patch queue-4.4/lib-ucs2_string-add-ucs2-utf8-helper-functions.patch