Patch "bnx2x: Don't notify about scratchpad parities" has been added to the 3.14-stable tree
This is a note to let you know that I've just added the patch titled
bnx2x: Don't notify about scratchpad parities
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
bnx2x-don-t-notify-about-scratchpad-parities.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ad6afbe9578d1fa26680faf78c846bd8c00d1d6eMon Sep 17 00:00:00 2001
From: Manish Chopra <[email protected]>
Date: Thu, 25 Jun 2015 15:19:24 +0300
Subject: bnx2x: Don't notify about scratchpad parities
From: Manish Chopra <[email protected]>
commit ad6afbe9578d1fa26680faf78c846bd8c00d1d6e upstream.
The scratchpad is a shared block between all functions of a given device. Due to HW limitations, we can't properly close its parity notifications to all functions on legal flows.
E.g., it's possible that while taking a register dump from one function a parity error would be triggered on other functions.
Today driver doesn't consider this parity as a 'real' parity unless its being accompanied by additional indications [which would happen in a real parity scenario]; But it does print notifications for such events in the system logs.
This eliminates such prints - in case of real parities driver would have additional indications; But if this is the only signal user will not even see a parity being logged in the system.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 11 +++++++---- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 20 ++++++++++++++------ 2 files changed, 21 insertions(+), 10 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h +7 -4
@@ -2401,10 +2401,13 @@ void bnx2x_igu_clear_sb_gen(struct bnx2x AEU_INPUTS_ATTN_BITS_IGU_PARITY_ERROR | \ AEU_INPUTS_ATTN_BITS_MISC_PARITY_ERROR) -#define HW_PRTY_ASSERT_SET_3 (AEU_INPUTS_ATTN_BITS_MCP_LATCHED_ROM_PARITY | \ - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_RX_PARITY | \ - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_TX_PARITY | \ - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY) +#define HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD \ + (AEU_INPUTS_ATTN_BITS_MCP_LATCHED_ROM_PARITY | \ + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_RX_PARITY | \ + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_TX_PARITY) + +#define HW_PRTY_ASSERT_SET_3 (HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD | \ + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY)#define HW_PRTY_ASSERT_SET_4 (AEU_INPUTS_ATTN_BITS_PGLUE_PARITY_ERROR | \ AEU_INPUTS_ATTN_BITS_ATC_PARITY_ERROR)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +14 -6
@@ -4631,9 +4631,7 @@ static bool bnx2x_check_blocks_with_pari res |= true;break ;case AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY : -if (print) -_print_next_block ((*par_num)++, -"MCP SCPAD" ); + (*par_num)++;/* clear latched SCPAD PATIRY from MCP */ REG_WR (bp,MISC_REG_AEU_CLR_LATCH_SIGNAL ,1UL <<10 );
@@ -4695,6 +4693,7 @@ static bool bnx2x_parity_attn(struct bnx (sig[3] & HW_PRTY_ASSERT_SET_3) || (sig[4] & HW_PRTY_ASSERT_SET_4)) {int par_num =0 ; + DP(NETIF_MSG_HW, "Was parity error: HW block parity attention:\n" "[0]:0x%08x [1]:0x%08x [2]:0x%08x [3]:0x%08x [4]:0x%08x\n", sig[0] & HW_PRTY_ASSERT_SET_0,
@@ -4702,9 +4701,18 @@ static bool bnx2x_parity_attn(struct bnx sig[2 ] &HW_PRTY_ASSERT_SET_2 , sig[3 ] &HW_PRTY_ASSERT_SET_3 , sig[4] & HW_PRTY_ASSERT_SET_4); -if (print) -netdev_err (bp->dev, -"Parity errors detected in blocks: " ); +if (print) { +if (((sig[0 ] &HW_PRTY_ASSERT_SET_0 ) || + (sig[1 ] &HW_PRTY_ASSERT_SET_1 ) || + (sig[2 ] &HW_PRTY_ASSERT_SET_2 ) || + (sig[4 ] &HW_PRTY_ASSERT_SET_4 )) || + (sig[3 ] &HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD )) { +netdev_err (bp->dev, +"Parity errors detected in blocks: " ); + }else { + print = false; + } + } res |=bnx2x_check_blocks_with_parity0 (bp, sig[0 ] &HW_PRTY_ASSERT_SET_0 , &par_num, print); res |= bnx2x_check_blocks_with_parity1(bp,
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/bnx2x-don-t-notify-about-scratchpad-parities.patch