Skip to contentSkip to conversation

Patch "devres: fix a for loop bounds check" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

devres: fix a for loop bounds check

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
devres-fix-a-for-loop-bounds-check.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1f35d04a02a652f14566f875aef3a6f2af4cb77b Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Mon, 21 Sep 2015 19:21:51 +0300
Subject: devres: fix a for loop bounds check

From: Dan Carpenter <[email protected]>

commit 1f35d04a02a652f14566f875aef3a6f2af4cb77b upstream.

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. It may be that the "if (!(mask & (1 << i)))" check means we never actually go past the end of the array in real life.

Fixes ec04b075843d ('iomap: implement pcim_iounmap_regions()')
---
 lib/devres.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/devres.c +1 -1
@@ -423,7 +423,7 @@ void pcim_iounmap_regions(struct pci_dev
 	if (!iomap)
 		return;
 
-	for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+	for (i = 0; i < PCIM_IOMAP_MAX; i++) {
 		if (!(mask & (1 << i)))
 			continue;
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/devres-fix-a-for-loop-bounds-check.patch