Skip to contentSkip to conversation

Patch "scripts: recordmcount: break hardlinks" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

scripts: recordmcount: break hardlinks

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
scripts-recordmcount-break-hardlinks.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dd39a26538e37f6c6131e829a4a510787e43c783 Mon Sep 17 00:00:00 2001

From: Russell King <[email protected]>
Date: Fri, 11 Dec 2015 12:09:03 +0000
Subject: scripts: recordmcount: break hardlinks

From: Russell King <[email protected]>

commit dd39a26538e37f6c6131e829a4a510787e43c783 upstream.

recordmcount edits the file in-place, which can cause problems when using ccache in hardlink mode. Arrange for recordmcount to break a hardlinked object.

---
 scripts/recordmcount.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
scripts/recordmcount.c +14 -0
@@ -189,6 +189,20 @@ static void *mmap_file(char const *fname
 		addr = umalloc(sb.st_size);
 		uread(fd_map, addr, sb.st_size);
 	}
+	if (sb.st_nlink != 1) {
+		/* file is hard-linked, break the hard link */
+		close(fd_map);
+		if (unlink(fname) < 0) {
+			perror(fname);
+			fail_file();
+		}
+		fd_map = open(fname, O_RDWR | O_CREAT, sb.st_mode);
+		if (fd_map < 0) {
+			perror(fname);
+			fail_file();
+		}
+		uwrite(fd_map, addr, sb.st_size);
+	}
 	return addr;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/scripts-recordmcount-break-hardlinks.patch