Skip to contentSkip to conversation

Patch "Btrfs: add missing brelse when superblock checksum fails" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Btrfs: add missing brelse when superblock checksum fails

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
btrfs-add-missing-brelse-when-superblock-checksum-fails.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b2acdddfad13c38a1e8b927d83c3cf321f63601a Mon Sep 17 00:00:00 2001

From: Anand Jain <[email protected]>
Date: Wed, 7 Oct 2015 17:23:23 +0800
Subject: Btrfs: add missing brelse when superblock checksum fails

From: Anand Jain <[email protected]>

commit b2acdddfad13c38a1e8b927d83c3cf321f63601a upstream.

Looks like oversight, call brelse() when checksum fails. Further down the code, in the non error path, we do call brelse() and so we don't see brelse() in the goto error paths.

---
 fs/btrfs/disk-io.c |    1 +
 1 file changed, 1 insertion(+)
fs/btrfs/disk-io.c +1 -0
@@ -2437,6 +2437,7 @@ int open_ctree(struct super_block *sb,
 		       "unsupported option features (%Lx).\n",
 		       (unsigned long long)features);
 		err = -EINVAL;
+		brelse(bh);
 		goto fail_alloc;
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/btrfs-add-missing-brelse-when-superblock-checksum-fails.patch