Skip to contentSkip to conversation

Patch "dm space map metadata: remove unused variable in brb_pop()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

dm space map metadata: remove unused variable in brb_pop()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
dm-space-map-metadata-remove-unused-variable-in-brb_pop.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 512167788a6fe9481a33a3cce5f80b684631a1bb Mon Sep 17 00:00:00 2001

From: Mike Snitzer <[email protected]>
Date: Mon, 14 Dec 2015 09:26:01 -0500
Subject: dm space map metadata: remove unused variable in brb_pop()

From: Mike Snitzer <[email protected]>

commit 512167788a6fe9481a33a3cce5f80b684631a1bb upstream.

Remove the unused struct block_op pointer that was inadvertantly introduced, via cut-and-paste of previous brb_op() code, as part of commit 50dd842ad.

(Cc'ing stable@ because commit 50dd842ad did)

Fixes 50dd842ad ("dm space map metadata: fix ref counting bug when bootstrapping a new space map")
---
 drivers/md/persistent-data/dm-space-map-metadata.c |    3 ---
 1 file changed, 3 deletions(-)
drivers/md/persistent-data/dm-space-map-metadata.c +0 -3
@@ -152,12 +152,9 @@ static int brb_peek(struct bop_ring_buff
 
 static int brb_pop(struct bop_ring_buffer *brb)
 {
-	struct block_op *bop;
-
 	if (brb_empty(brb))
 		return -ENODATA;
 
-	bop = brb->bops + brb->begin;
 	brb->begin = brb_next(brb, brb->begin);
 
 	return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/dm-snapshot-fix-hung-bios-when-copy-error-occurs.patch queue-4.4/dm-space-map-metadata-remove-unused-variable-in-brb_pop.patch queue-4.4/dm-fix-dm_rq_target_io-leak-on-faults-with-.request_fn-dm-w-blk-mq-paths.patch queue-4.4/dm-thin-fix-race-condition-when-destroying-thin-pool-workqueue.patch