Patch "rtlwifi: rtl8723be: Fix module parameter initialization" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled

rtlwifi: rtl8723be: Fix module parameter initialization

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rtlwifi-rtl8723be-fix-module-parameter-initialization.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Larry Finger <[email protected]>
Date: Mon, 14 Dec 2015 16:34:31 -0600
Subject: rtlwifi: rtl8723be: Fix module parameter initialization

From: Larry Finger <[email protected]>

commit 7079604ddb83f428359feace3aeaf8a9f435be4a upstream.

This driver has a number of errors in the module initialization. These include the following:

Parameter msi_support is stored in two places - one is removed. Paramters sw_crypto and disable_watchdog were never stored in the final locations, nor were they initialized properly.

---
 drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

@@ -93,7 +93,6 @@ int rtl8723be_init_sw_vars(struct ieee80
 	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
 
 	rtl8723be_bt_reg_init(hw);
-	rtlpci->msi_support = rtlpriv->cfg->mod_params->msi_support;
 	rtlpriv->btcoexist.btc_ops = rtl_btc_get_ops_pointer();
 
 	rtlpriv->dm.dm_initialgain_enable = 1;

@@ -151,6 +150,10 @@ int rtl8723be_init_sw_vars(struct ieee80
 	rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;
 	rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;
 	rtlpci->msi_support = rtlpriv->cfg->mod_params->msi_support;
+	rtlpriv->cfg->mod_params->sw_crypto =
+		 rtlpriv->cfg->mod_params->sw_crypto;
+	rtlpriv->cfg->mod_params->disable_watchdog =
+		 rtlpriv->cfg->mod_params->disable_watchdog;
 	if (rtlpriv->cfg->mod_params->disable_watchdog)
 		pr_info("watchdog disabled\n");
 	rtlpriv->psc.reg_fwctrl_lps = 3;

@@ -267,6 +270,9 @@ static struct rtl_mod_params rtl8723be_m
 	.inactiveps = true,
 	.swctrl_lps = false,
 	.fwctrl_lps = true,
+	.msi_support = false,
+	.disable_watchdog = false,
+	.debug = DBG_EMERG,
 };
 
 static struct rtl_hal_cfg rtl8723be_hal_cfg = {

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/rtlwifi-rtl8723be-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192de-fix-incorrect-module-parameter-descriptions.patch queue-4.4/rtlwifi-rtl8192se-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192cu-add-missing-parameter-setup.patch queue-4.4/rtlwifi-rtl8723ae-fix-initialization-of-module-parameters.patch queue-4.4/rtlwifi-rtl_pci-fix-kernel-panic.patch queue-4.4/rtlwifi-rtl8188ee-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192ce-fix-handling-of-module-parameters.patch