Skip to contentSkip to conversation

Patch "[media] si2157: return -EINVAL if firmware blob is too big" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] si2157: return -EINVAL if firmware blob is too big

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
si2157-return-einval-if-firmware-blob-is-too-big.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From d2cc2f0b35465951eaaf0387fd55e29835ed7ea6 Mon Sep 17 00:00:00 2001

From: Laura Abbott <[email protected]>
Date: Mon, 5 Oct 2015 19:33:29 -0300
Subject: [media] si2157: return -EINVAL if firmware blob is too big

From: Laura Abbott <[email protected]>

commit d2cc2f0b35465951eaaf0387fd55e29835ed7ea6 upstream.

A previous patch added a check if the firmware is too big, but it didn't set the return error code with the right value.

[[email protected]: I ended by applying a v1 of Laura's patch, without
the proper return code. This patch contains the difference between v2 and v1 of the Laura's "si2157: Bounds check firmware" patch]

---
 drivers/media/tuners/si2157.c |    1 +
 1 file changed, 1 insertion(+)
drivers/media/tuners/si2157.c +1 -0
@@ -168,6 +168,7 @@ static int si2157_init(struct dvb_fronte
 		len = fw->data[fw->size - remaining];
 		if (len > SI2157_ARGLEN) {
 			dev_err(&client->dev, "Bad firmware length\n");
+			ret = -EINVAL;
 			goto err_release_firmware;
 		}
 		memcpy(cmd.args, &fw->data[(fw->size - remaining) + 1], len);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/si2157-return-einval-if-firmware-blob-is-too-big.patch