Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/i915: fix error path in intel_setup_gmbus()" failed to apply to 3.14-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 3.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From ed3f9fd1e865975ceefdb2a43b453e090b1fd787 Mon Sep 17 00:00:00 2001

From: Rasmus Villemoes <[email protected]>
Date: Tue, 9 Feb 2016 21:11:13 +0100
Subject: [PATCH] drm/i915: fix error path in intel_setup_gmbus()

This fails to undo the setup for pin==0; moreover, something interesting happens if the setup failed already at pin==0.

Fixes f899fc64cda8 ("drm/i915: use GMBUS to manage i2c links")
(cherry picked from commit 2417c8c03f508841b85bf61acc91836b7b0e2560)
drivers/gpu/drm/i915/intel_i2c.c +1 -1
index 25254b5c1ac5..deb8282c26d8 100644
@@ -683,7 +683,7 @@ int intel_setup_gmbus(struct drm_device *dev)
 	return 0;
 
 err:
-	while (--pin) {
+	while (pin--) {
 		if (!intel_gmbus_is_valid_pin(dev_priv, pin))
 			continue;