Skip to contentSkip to conversation

Patch "lib: sw842: select crc32" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    lib: sw842: select crc32

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     lib-sw842-select-crc32.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5b57167749274961baf15ed1f05a4996b3ab0487 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Wed, 13 Jan 2016 23:24:02 +0100
Subject: lib: sw842: select crc32

From: Arnd Bergmann <[email protected]>

commit 5b57167749274961baf15ed1f05a4996b3ab0487 upstream.

The sw842 library code was merged in linux-4.1 and causes a very rare randconfig failure when CONFIG_CRC32 is not set:

lib/built-in.o: In function `sw842_compress':
oid_registry.c:(.text+0x12ddc): undefined reference to crc32_be' lib/built-in.o: In function sw842_decompress':
oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'

This adds an explict 'select CRC32' statement, similar to what the other users of the crc32 code have. In practice, CRC32 is always enabled anyway because over 100 other symbols select it.

Fixes 2da572c959dd ("lib: add software 842 compression/decompression")
---
 lib/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
lib/Kconfig +2 -0
@@ -210,9 +210,11 @@ config RANDOM32_SELFTEST
 # compression support is select'ed if needed
 #
 config 842_COMPRESS
+	select CRC32
 	tristate
 
 config 842_DECOMPRESS
+	select CRC32
 	tristate
 
 config ZLIB_INFLATE

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/arm-8457-1-psci-smp-is-built-only-for-smp.patch queue-4.4/lib-sw842-select-crc32.patch queue-4.4/cputime-prevent-32bit-overflow-in-time_to_cputime.patch queue-4.4/arm-debug-ll-fix-bcm63xx-entry-for-multiplatform.patch queue-4.4/cpufreq-pxa2xx-fix-pxa_cpufreq_change_voltage-prototype.patch