Skip to contentSkip to conversation

Patch "x86/entry/compat: Add missing CLAC to entry_INT80_32" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

x86/entry/compat: Add missing CLAC to entry_INT80_32

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     x86-entry-compat-add-missing-clac-to-entry_int80_32.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3d44d51bd339766f0178f0cf2e8d048b4a4872aa Mon Sep 17 00:00:00 2001

From: Andy Lutomirski <[email protected]>
Date: Wed, 24 Feb 2016 12:18:49 -0800
Subject: x86/entry/compat: Add missing CLAC to entry_INT80_32

From: Andy Lutomirski <[email protected]>

commit 3d44d51bd339766f0178f0cf2e8d048b4a4872aa upstream.

This doesn't seem to fix a regression -- I don't think the CLAC was ever there.

I double-checked in a debugger: entries through the int80 gate do not automatically clear AC.

Stable maintainers: I can provide a backport to 4.3 and earlier if needed. This needs to be backported all the way to 3.10.

Cc Andy Lutomirski <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Denys Vlasenko <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Fixes 63bcff2a307b ("x86, smap: Add STAC and CLAC instructions to control user space access")
---
 arch/x86/entry/entry_64_compat.S |    1 +
 1 file changed, 1 insertion(+)
arch/x86/entry/entry_64_compat.S +1 -0
@@ -267,6 +267,7 @@ ENTRY(entry_INT80_compat)
 	 * Interrupts are off on entry.
 	 */
 	PARAVIRT_ADJUST_EXCEPTION_FRAME
+	ASM_CLAC			/* Do this early to minimize exposure */
 	SWAPGS
 
 	/*

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/x86-entry-compat-add-missing-clac-to-entry_int80_32.patch